Attachment 17513 Details for Bug 10072 – Bug 10072 - "my suggestions" always says "There are no pending purchase suggestions."

[patch] Bug 10072 - "my suggestions" always says "There are no pending purchase suggestions."

Bug-10072---my-suggestions-always-says-There-are-n.patch (text/plain), 1.10 KB, created by Kyle M Hall (khall) on 2013-04-17 18:09:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-04-17 18:09:28 UTC

Size: 1.10 KB

patch

obsolete

>From a6265274fcd0bd3067aea027f2971fc2493ed70e Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 17 Apr 2013 14:07:55 -0400
>Subject: [PATCH] Bug 10072 - "my suggestions" always says "There are no pending purchase suggestions."
>
>Test Plan:
>1) Log into the OPAC
>2) Place a suggestions
>3) Instead of seeing your suggestion, you will see "There are no pending
>   purchase suggestions."
>4) Apply this patch
>5) Reload the page
>6) You should now see your suggestions
>---
> C4/Suggestions.pm |    6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
>diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm
>index 131f117..81f77a2 100644
>--- a/C4/Suggestions.pm
>+++ b/C4/Suggestions.pm
>@@ -149,11 +149,7 @@ sub SearchSuggestion {
>                 push @sql_params, $suggestion->{branchcode};
>                 push @query,      qq{ AND suggestions.branchcode=? };
>             }
>-        } else {
>-            push @query, qq{
>-                AND (suggestions.branchcode='' OR suggestions.branchcode IS NULL)
>-            };
>-        }
>+        } 
>     }
> 
>     # filter on nillable fields
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 10072: 17513 | 17515 | 17551