Bugzilla – Attachment 175174 Details for
Bug 35709
[23.11] Renew selected items button is inactive when overdue items are preselected automatically
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35709: 23.11 version of bug 36060
Bug-35709-2311-version-of-bug-36060.patch (text/plain), 4.72 KB, created by
Baptiste Wojtkowski (bwoj)
on 2024-12-04 13:13:52 UTC
(
hide
)
Description:
Bug 35709: 23.11 version of bug 36060
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2024-12-04 13:13:52 UTC
Size:
4.72 KB
patch
obsolete
>From 65e0ed9e960cb3c0f940b97fb905305c487e06b9 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 4 Dec 2024 12:33:58 +0000 >Subject: [PATCH] Bug 35709: 23.11 version of bug 36060 > >This just replicates the logic of bug 36060 for the 23.11.x branch. >Follow the same test plan as for that bug. > >Signed-off-by: Baptiste <baptiste.wojtkowski@biblibre.com> >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 27 ++++++++++++-------- > 1 file changed, 16 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 6cad61f7d26..ea25eb89c43 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -26,17 +26,22 @@ $(document).ready(function() { > } > }; > >+ var CheckRenewCheckinBoxes = function() { >+ $('#RenewChecked').prop('disabled', !$('.renew:checked').length ); >+ $('#CheckinChecked').prop('disabled', !$('.checkin:checked').length ); >+ } >+ > // Handle the select all/none links for checkouts table columns > $("#CheckAllRenewals").on("click",function(){ > $("#UncheckAllCheckins").click(); > $(".renew:visible").prop("checked", true); >- $('#RenewChecked').prop('disabled', !$('.renew:checked').length ); >+ CheckRenewCheckinBoxes(); > showHideOnHoldRenewal(); > return false; > }); > $("#UncheckAllRenewals").on("click",function(){ > $(".renew:visible").prop("checked", false); >- $('#RenewChecked').prop('disabled', !$('.renew:checked').length ); >+ CheckRenewCheckinBoxes(); > showHideOnHoldRenewal(); > return false; > }); >@@ -44,12 +49,12 @@ $(document).ready(function() { > $("#CheckAllCheckins").on("click",function(){ > $("#UncheckAllRenewals").click(); > $(".checkin:visible").prop("checked", true); >- $('#CheckinChecked').prop('disabled', !$('.checkin:checked').length ); >+ CheckRenewCheckinBoxes(); > return false; > }); > $("#UncheckAllCheckins").on("click",function(){ > $(".checkin:visible").prop("checked", false); >- $('#CheckinChecked').prop('disabled', !$('.checkin:checked').length ); >+ CheckRenewCheckinBoxes(); > return false; > }); > >@@ -68,15 +73,13 @@ $(document).ready(function() { > if ( $(this).is(":checked") ) { > $( "#checkin_" + $(this).val() ).prop("checked", false); > } >- $('#CheckinChecked').prop('disabled', !$('.checkin:checked').length ); >- $('#RenewChecked').prop('disabled', !$('.renew:checked').length ); >+ CheckRenewCheckinBoxes(); > }); > $(document).on("change", '.checkin', function(){ > if ( $(this).is(":checked") ) { > $( "#renew_" + $(this).val() ).prop("checked", false); > } >- $('#CheckinChecked').prop('disabled', !$('.checkin:checked').length ); >- $('#RenewChecked').prop('disabled', !$('.renew:checked').length ); >+ CheckRenewCheckinBoxes(); > }); > > // Display on hold due dates input when an on hold item is >@@ -154,7 +157,7 @@ $(document).ready(function() { > if ( refresh_table ) { > RefreshIssuesTable(); > } >- $('#RenewChecked, #CheckinChecked').prop('disabled' , true ); >+ CheckRenewCheckinBoxes(); > // Prevent form submit > return false; > }); >@@ -248,6 +251,7 @@ $(document).ready(function() { > > if ( refresh_table ) { > RefreshIssuesTable(); >+ CheckRenewCheckinBoxes(); > } > // Prevent form submit > return false; >@@ -258,7 +262,7 @@ $(document).ready(function() { > $("#UncheckAllCheckins").click(); > showHideOnHoldRenewal(); > $("#RenewChecked").click(); >- $('#RenewChecked').prop('disabled' , true ); >+ CheckRenewCheckinBoxes(); > // Prevent form submit > return false; > }); >@@ -301,7 +305,7 @@ $(document).ready(function() { > return this.value; > }).get(); > table.ajax.reload( function() { >- $('#RenewChecked, #CheckinChecked').prop('disabled' , true ); >+ CheckRenewCheckinBoxes(); > if ( renewchecked.length ) { > $('#RenewChecked').prop('disabled' , false ); > renewchecked.forEach( function(checked) { >@@ -728,6 +732,7 @@ $(document).ready(function() { > } > }, > "initComplete": function(oSettings, json) { >+ CheckRenewCheckinBoxes(); > // Build a summary of checkouts grouped by itemtype > var checkoutsByItype = json.aaData.reduce(function (obj, row) { > obj[row.type_for_stat] = (obj[row.type_for_stat] || 0) + 1; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35709
:
160574
|
175172
| 175174