Bugzilla – Attachment 175395 Details for
Bug 38684
Improve translatability in cat-toolbar.inc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38684: Improve translatability in cat-toolbar.inc
Bug-38684-Improve-translatability-in-cat-toolbarin.patch (text/plain), 3.08 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-12-12 11:32:29 UTC
(
hide
)
Description:
Bug 38684: Improve translatability in cat-toolbar.inc
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-12-12 11:32:29 UTC
Size:
3.08 KB
patch
obsolete
>From 696772317faa2687b8999d949190f05d5585888b Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 12 Dec 2024 08:25:41 -0300 >Subject: [PATCH] Bug 38684: Improve translatability in cat-toolbar.inc > >This patch converts strings using > >* *subscription(s)* >* *item(s)* > >into different strings for the singular and plural forms. This helps >translating and is also more accurate for the end user. > >To test: >1. Have a record with 2 items and 2 subscriptions >2. hover on the _Edit > Delete record_ dropdown item >=> FAIL: Mixed form string about items >3. Delete one item at a time, repeating 2 >=> FAIL: Mixed form string at each step >4. Once items are deleted, repeat 2 >=> FAIL: Mixed form string about subscriptions >5. Delete one subscription at a time, repeating 2 >=> FAIL: Mixed form string at each step >6. Apply this patch >7. Repeat 1-5 >=> SUCCESS: Different message in singular and plural forms >=> SUCCESS: The message is correct >8. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >index 36d924b9524..2246ae2b24f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >@@ -130,11 +130,12 @@ > > [% IF CAN_user_editcatalogue_edit_catalogue or ( frameworkcode == 'FA' and CAN_user_editcatalogue_fast_cataloging ) %] > [% IF ( count ) %] >- <li data-bs-toggle="tooltip" data-bs-placement="left" title="[% count | html %] item(s) are attached to this record. You must delete all items before deleting this record"> >+ <li data-bs-toggle="tooltip" data-bs-placement="left" title="[%- I18N.tnx("There is an item attached to this record", "There are {count} items attached to this record", count, { count => count }) -%]. You must delete all items before deleting this record"> > <a class="dropdown-item disabled" aria-disabled="true" id="deletebiblio" href="#">Delete record</a> > </li> > [% ELSIF ( biblio.subscriptions.count ) %] >- <li data-bs-toggle="tooltip" data-bs-placement="left" title="[% biblio.subscriptions.count | html %] subscription(s) are attached to this record. You must delete all subscriptions before deleting this record"> >+ [%- SET subscriptions_count = biblio.subscriptions.count -%] >+ <li data-bs-toggle="tooltip" data-bs-placement="left" title="[%- I18N.tnx("There is a subscription attached to this record", "There are {count} subscription attached to this record", subscriptions_count, { count => subscriptions_count }) -%]. You must delete all subscriptions before deleting this record"> > <a class="dropdown-item disabled" aria-disabled="true" id="deletebiblio" href="#">Delete record</a> > </li> > [% ELSE %] >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38684
:
175395
|
175464
|
176048
|
176049