There are two strings that could use `I18N.tnx` to improve translatability.
Created attachment 175395 [details] [review] Bug 38684: Improve translatability in cat-toolbar.inc This patch converts strings using * *subscription(s)* * *item(s)* into different strings for the singular and plural forms. This helps translating and is also more accurate for the end user. To test: 1. Have a record with 2 items and 2 subscriptions 2. hover on the _Edit > Delete record_ dropdown item => FAIL: Mixed form string about items 3. Delete one item at a time, repeating 2 => FAIL: Mixed form string at each step 4. Once items are deleted, repeat 2 => FAIL: Mixed form string about subscriptions 5. Delete one subscription at a time, repeating 2 => FAIL: Mixed form string at each step 6. Apply this patch 7. Repeat 1-5 => SUCCESS: Different message in singular and plural forms => SUCCESS: The message is correct 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 175464 [details] [review] Bug 38684: Improve translatability in cat-toolbar.inc This patch converts strings using * *subscription(s)* * *item(s)* into different strings for the singular and plural forms. This helps translating and is also more accurate for the end user. To test: 1. Have a record with 2 items and 2 subscriptions 2. hover on the _Edit > Delete record_ dropdown item => FAIL: Mixed form string about items 3. Delete one item at a time, repeating 2 => FAIL: Mixed form string at each step 4. Once items are deleted, repeat 2 => FAIL: Mixed form string about subscriptions 5. Delete one subscription at a time, repeating 2 => FAIL: Mixed form string at each step 6. Apply this patch 7. Repeat 1-5 => SUCCESS: Different message in singular and plural forms => SUCCESS: The message is correct 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA by RM.
Pushed for 25.05! Well done everyone, thank you!
$ koha-translate --update fr-CA --dev kohadev Can't use an undefined value as a HASH reference at /kohadevbox/koha/misc/translator/tmpl_process3.pl line 134. git blaming this patch.
Created attachment 176048 [details] [review] Bug 38684: FIX2 Fix koha-translate
2 possible fixes. I think the second one is better. More work/duplication for translators but at least it's clear and there is no weirdness with punctuation. Note that it would be good to include something about testing the translation workflow when we "improve the translatability" ;)
Created attachment 176049 [details] [review] Bug 38684: FIX1 Fix koha-translate
(In reply to Jonathan Druart from comment #7) > 2 possible fixes. > > I think the second one is better. Which is the first one submitted :D "FIX2" is better!
I need to check the diff of these with git... currently not spotting the difference.
OK; I picked FIX2, but made the commit message a little nicer. --color-words=. is helpful.
Oops. Thanks Jonathan.
(In reply to Jonathan Druart from comment #7) > I think the second one is better. More work/duplication for translators but > at least it's clear and there is no weirdness with punctuation. Agreed