Bugzilla – Attachment 175581 Details for
Bug 38077
Minor spacing issue in self checkout login page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38077: Fix minor spacing issue in self checkout login page
Bug-38077-Fix-minor-spacing-issue-in-self-checkout.patch (text/plain), 7.69 KB, created by
David Nind
on 2024-12-16 23:32:17 UTC
(
hide
)
Description:
Bug 38077: Fix minor spacing issue in self checkout login page
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-12-16 23:32:17 UTC
Size:
7.69 KB
patch
obsolete
>From 9d7c8ea67cda428d2e7ceb2ee29c5b9280e7f71b Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 16 Dec 2024 19:25:01 +0000 >Subject: [PATCH] Bug 38077: Fix minor spacing issue in self checkout login > page > >This patch adjusts the markup and CSS of the self checkout login screen >so that form layout is consistent and readable. I have adjusted the >template conditional so that it re-uses more form elements like ><legend>. > >To test, apply the patch and enable WebBasedSelfCheck if necessary. > >- Set the SelfCheckoutByLogin system preference to 'cardnumber' >- Go to the self-checkout page (/cgi-bin/koha/sco/sco-main.pl) > - The login form should be labeled "Log in to your account" followed > by the label, form field, and submit button arranged vertically. >- Set the SelfCheckoutByLogin preference to "username and password" >- Reload the self-checkout page. The form should look the same with the > addition of the password field. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: David Nind <david@davidnind.com> >--- > .../opac-tmpl/bootstrap/css/src/sco.scss | 4 +- > .../bootstrap/en/modules/sco/sco-main.tt | 61 +++++++++++-------- > 2 files changed, 39 insertions(+), 26 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss >index 9fad8a7c8e..64e6063397 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss >@@ -64,8 +64,8 @@ a { > .sco_entry { > margin: 2rem 0; > >- label { >- text-align: right; >+ div[class^="col-"] { >+ margin: .2em 0; > } > } > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index 1e68d62898..92c4b69146 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -464,35 +464,48 @@ > <form id="mainform" action="/cgi-bin/koha/sco/sco-main.pl" name="mainform" method="post"> > [% INCLUDE 'csrf-token.inc' %] > <fieldset> >- [% IF ( Koha.Preference('SelfCheckoutByLogin') ) %] >- <legend>Log in to your account</legend> >- [% PROCESS login_label for="patronlogin" %] >- <input type="text" id="patronlogin" class="focus noEnterSubmit" size="20" name="patronlogin" autocomplete="off"/> >- <label for="patronpw">Password:</label> >- <input type="password" id="patronpw" size="20" name="patronpw" autocomplete="off"/> >- <fieldset class="action"> >- <button type="submit" class="btn btn-primary">Log in</button> >- </fieldset> >- [% ELSE %] >- <div class="form-row"> >- <div class="col-auto"> >- <label for="patronid">Please enter your card number:</label> >- </div> >- <div class="col-3"> >- <input type="text" id="patronid" class="form-control focus" size="20" name="patronid" autocomplete="off" /> >- </div> >- <div class="col-auto"> >- <button type="submit" class="btn btn-primary">Submit</button> >- </div> >- </div> <!-- /.form-row --> >- [% END %] >- >+ <legend>Log in to your account</legend> >+ <div class="row"> >+ <div class="col-md-6"> >+ [% IF ( Koha.Preference('SelfCheckoutByLogin') ) %] >+ <div class="row"> >+ <div class="col-md-12"> >+ [% PROCESS login_label for="patronlogin" %] >+ </div> >+ <div class="col-md-12"> >+ <input type="text" id="patronlogin" class="form-control focus noEnterSubmit" size="20" name="patronlogin" autocomplete="off"/> >+ </div> >+ <div class="col-md-12"> >+ <label for="patronpw">Password:</label> >+ </div> >+ <div class="col-md-12"> >+ <input type="password" id="patronpw" class="form-control" size="20" name="patronpw" autocomplete="off"/> >+ </div> >+ <div class="col-md-12"> >+ <button type="submit" class="btn btn-primary">Log in</button> >+ </div> >+ </div> <!-- /.row --> >+ [% ELSE %] >+ <div class="row"> >+ <div class="col-md-12"> >+ <label for="patronid">Please enter your card number:</label> >+ </div> >+ <div class="col-md-12"> >+ <input type="text" id="patronid" class="form-control focus" size="20" name="patronid" autocomplete="off" /> >+ </div> >+ <div class="col-md-12"> >+ <button type="submit" class="btn btn-primary">Submit</button> >+ </div> >+ </div> <!-- /.row --> >+ [% END %] >+ </div> <!-- /.col-md-6 --> >+ </div> <!-- /.row --> > [% FOREACH INPUT IN INPUTS %] > <input type="hidden" name="[% INPUT.name | html %]" value="[% INPUT.value | html %]"> > [% END %] > <input type="hidden" name="op" value="cud-login" /> > </fieldset> >- </form> >+ </form> <!-- /#mainform --> > </div> <!-- / .sco_entry --> > [% END # / IF validuser %] > [% END # / UNLESS ( hide_main %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38077
:
175576
| 175581