When accessing the sco-main.pl page, there is no space between the password field and the login button. A little padding there would look better. To get there: If using KTD, 1. Go to http://kohadev.mydnsname.org:8080/cgi-bin/koha/sco/sco-main.pl If not using KTD, 1. Create a patron with the self_checkout_module permission 2. In system preferences, - set WebBasedSelfCheck to Enable - set AutoSelfCheckAllowed to Allow - enter the login of the patron created in step 1 in AutoSelfCheckID - enter the password of the patron created in step 1 in AutoSelfCheckPass 3. Go to opac/cgi-bin/koha/sco/sco-main.pl
Same thing if SelfCheckoutByLogin is set to cardnumber.
Created attachment 175576 [details] [review] Bug 38077: Fix minor spacing issue in self checkout login page This patch adjusts the markup and CSS of the self checkout login screen so that form layout is consistent and readable. I have adjusted the template conditional so that it re-uses more form elements like <legend>. To test, apply the patch and enable WebBasedSelfCheck if necessary. - Set the SelfCheckoutByLogin system preference to 'cardnumber' - Go to the self-checkout page (/cgi-bin/koha/sco/sco-main.pl) - The login form should be labeled "Log in to your account" followed by the label, form field, and submit button arranged vertically. - Set the SelfCheckoutByLogin preference to "username and password" - Reload the self-checkout page. The form should look the same with the addition of the password field. Sponsored-by: Athens County Public Libraries
Created attachment 175581 [details] [review] Bug 38077: Fix minor spacing issue in self checkout login page This patch adjusts the markup and CSS of the self checkout login screen so that form layout is consistent and readable. I have adjusted the template conditional so that it re-uses more form elements like <legend>. To test, apply the patch and enable WebBasedSelfCheck if necessary. - Set the SelfCheckoutByLogin system preference to 'cardnumber' - Go to the self-checkout page (/cgi-bin/koha/sco/sco-main.pl) - The login form should be labeled "Log in to your account" followed by the label, form field, and submit button arranged vertically. - Set the SelfCheckoutByLogin preference to "username and password" - Reload the self-checkout page. The form should look the same with the addition of the password field. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. After applying the patch, run yarn build
QA by RM
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.03
Not backporting to 24.05.x unless requested