Attachment 175587 Details for Bug 38521 – Bug 38521: Add classes to reports homepage

[patch] Bug 38521: Add classes to reports homepage

Bug-38521-Add-classes-to-reports-homepage.patch (text/plain), 6.83 KB, created by Martin Renvoize (ashimema) on 2024-12-17 07:03:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-12-17 07:03:42 UTC

Size: 6.83 KB

patch

obsolete

>From 9f9ec015729e183ddc06fd2ac2a7c2399fe0f005 Mon Sep 17 00:00:00 2001
>From: Andrew Fuerste Henry <andrew@bywatersolutions.com>
>Date: Fri, 22 Nov 2024 18:13:07 +0000
>Subject: [PATCH] Bug 38521: Add classes to reports homepage
>
>To test:
>1 - inspect the page, see lack of distinct classes on separate sets of links
>2 - apply patch
>3 - reload page, confirm it looks and acts the same
>4 - inspect page, confirm classes for each set of links
>
>Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/reports/reports-home.tt   | 98 +++++++++++--------
> 1 file changed, 55 insertions(+), 43 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
>index 625f9a80d3e..a4b0f278294 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
>@@ -52,59 +52,71 @@
>                                 </form>
>                             </fieldset>
>                     [% END %]
>+        <div class="rep_dictonary">
>+            <h5>Reports dictionary</h5>
>+            <ul>
>+                <li><a href="/cgi-bin/koha/reports/dictionary.pl">View dictionary</a></li>
>+            </ul>
>+        </div>
> 
>-        <h5>Reports dictionary</h5>
>-        <ul>
>-            <li><a href="/cgi-bin/koha/reports/dictionary.pl">View dictionary</a></li>
>-        </ul>
>-
>-        <h2>Statistics wizards</h2>
>-        <ul>
>-            <li><a href="/cgi-bin/koha/reports/acquisitions_stats.pl">Acquisitions</a></li>
>-            <li><a href="/cgi-bin/koha/reports/borrowers_stats.pl">Patrons</a></li>
>-            <li><a href="/cgi-bin/koha/reports/catalogue_stats.pl">Catalog</a></li>
>-            <li><a href="/cgi-bin/koha/reports/issues_stats.pl">Circulation</a></li>
>-            <li><a href="/cgi-bin/koha/reports/serials_stats.pl">Serials</a></li>
>-            <li><a href="/cgi-bin/koha/reports/cash_register_stats.pl">Cash register</a></li>
>-            <li><a href="/cgi-bin/koha/reports/reserves_stats.pl">Holds</a></li>
>-      </ul>
>-
>-        [% IF plugins_enabled %]
>-            <h2>Report plugins</h2>
>+        <div class="rep_wizards">
>+            <h2>Statistics wizards</h2>
>             <ul>
>-                <li><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=report">Report plugins</a></li>
>+                <li><a href="/cgi-bin/koha/reports/acquisitions_stats.pl">Acquisitions</a></li>
>+                <li><a href="/cgi-bin/koha/reports/borrowers_stats.pl">Patrons</a></li>
>+                <li><a href="/cgi-bin/koha/reports/catalogue_stats.pl">Catalog</a></li>
>+                <li><a href="/cgi-bin/koha/reports/issues_stats.pl">Circulation</a></li>
>+                <li><a href="/cgi-bin/koha/reports/serials_stats.pl">Serials</a></li>
>+                <li><a href="/cgi-bin/koha/reports/cash_register_stats.pl">Cash register</a></li>
>+                <li><a href="/cgi-bin/koha/reports/reserves_stats.pl">Holds</a></li>
>             </ul>
>+        </div>
>+
>+        [% IF plugins_enabled %]
>+            <div class="rep_plugins">
>+                <h2>Report plugins</h2>
>+                <ul>
>+                    <li><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=report">Report plugins</a></li>
>+                </ul>
>+            </div>
>         [% END %]
> 
>     </div>
> 
>-    <div class="col-sm-12 col-md-6"><h2>Top lists</h2>
>-        <ul>
>-            <li><a href="/cgi-bin/koha/reports/bor_issues_top.pl">Patrons with the most checkouts</a></li>
>-            <li><a href="/cgi-bin/koha/reports/cat_issues_top.pl">Most-circulated items</a></li>
>-        </ul>
>+    <div class="col-sm-12 col-md-6">
>+        <div class="rep_top">
>+            <h2>Top lists</h2>
>+            <ul>
>+                <li><a href="/cgi-bin/koha/reports/bor_issues_top.pl">Patrons with the most checkouts</a></li>
>+                <li><a href="/cgi-bin/koha/reports/cat_issues_top.pl">Most-circulated items</a></li>
>+            </ul>
>+        </div>
> 
>-        <h2>Inactive</h2>
>-        <ul>
>-                <li><a href="/cgi-bin/koha/reports/borrowers_out.pl">Patrons who haven't checked out</a></li>
>-                <li><a href="/cgi-bin/koha/reports/catalogue_out.pl">Items with no checkouts</a></li>
>-        </ul>
>+        <div class="rep_inactive">
>+            <h2>Inactive</h2>
>+            <ul>
>+                    <li><a href="/cgi-bin/koha/reports/borrowers_out.pl">Patrons who haven't checked out</a></li>
>+                    <li><a href="/cgi-bin/koha/reports/catalogue_out.pl">Items with no checkouts</a></li>
>+            </ul>
>+        </div>
> 
>-        <h2>Other</h2>
>-        <ul>
>-            <li><a href="/cgi-bin/koha/reports/itemslost.pl">Items lost</a></li>
>-            <li><a href="/cgi-bin/koha/reports/orders_by_fund.pl">Orders by fund</a></li>
>-            <li><a href="/cgi-bin/koha/reports/catalog_by_itemtype.pl">Catalog by item type</a></li>
>-            <li><a href="/cgi-bin/koha/reports/issues_avg_stats.pl">Average loan time</a></li>
>-            [% SET koha_version = Koha.Version %]
>-            [% IF koha_version.development %]
>-                <li><a href="http://schema.koha-community.org/main" target="blank">Koha database schema</a></li>
>-            [% ELSE %]
>-                <li><a href="http://schema.koha-community.org/[% koha_version.major | uri %]_[% koha_version.minor | uri %]" target="blank">Koha database schema</a></li>
>-            [% END %]
>+        <div class="rep_other">
>+            <h2>Other</h2>
>+            <ul>
>+                <li><a href="/cgi-bin/koha/reports/itemslost.pl">Items lost</a></li>
>+                <li><a href="/cgi-bin/koha/reports/orders_by_fund.pl">Orders by fund</a></li>
>+                <li><a href="/cgi-bin/koha/reports/catalog_by_itemtype.pl">Catalog by item type</a></li>
>+                <li><a href="/cgi-bin/koha/reports/issues_avg_stats.pl">Average loan time</a></li>
>+                [% SET koha_version = Koha.Version %]
>+                [% IF koha_version.development %]
>+                    <li><a href="http://schema.koha-community.org/main" target="blank">Koha database schema</a></li>
>+                [% ELSE %]
>+                    <li><a href="http://schema.koha-community.org/[% koha_version.major | uri %]_[% koha_version.minor | uri %]" target="blank">Koha database schema</a></li>
>+                [% END %]
> 
>-            <li><a href="http://wiki.koha-community.org/wiki/SQL_Reports_Library" target="blank">Koha reports library</a></li>
>-        </ul>
>+                <li><a href="http://wiki.koha-community.org/wiki/SQL_Reports_Library" target="blank">Koha reports library</a></li>
>+            </ul>
>+        </div>
>         [% IF ( Koha.Preference('Mana') == 2 ) %]
>         <div class="alert alert-info" style="margin:15px 0 0 0";>
>             <strong>Knowledgebase</strong>
>-- 
>2.47.1

Actions: View | Diff | Splinter Review

Attachments on bug 38521: 174942 | 174985 | 175587 | 175588