Bugzilla – Attachment 175856 Details for
Bug 38174
Self checkout renders alert for each checkout in session instead of just most recent checkout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38174: Fix self checkout alerts for non batch checkouts
Bug-38174-Fix-self-checkout-alerts-for-non-batch-c.patch (text/plain), 2.99 KB, created by
Lucas Gass (lukeg)
on 2024-12-20 21:04:48 UTC
(
hide
)
Description:
Bug 38174: Fix self checkout alerts for non batch checkouts
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-12-20 21:04:48 UTC
Size:
2.99 KB
patch
obsolete
>From 13ecdbed9a1f571d3c2d39fcf0c1a8346e787c69 Mon Sep 17 00:00:00 2001 >From: Brendan Lawlor <blawlor@clamsnet.org> >Date: Tue, 15 Oct 2024 12:39:47 +0000 >Subject: [PATCH] Bug 38174: Fix self checkout alerts for non batch checkouts > >This patch adds a check for batch_checkouts_allowed to SCO. > >If not using batch checkout, only the most recent chekout should be >rendered as an alert, instead of all the new issues for the session. > >This makes the input box consitently render in the same position. > >To replicate: >1. Login as self_checkout to localhost:8080/cgi-bin/koha/sco/sco-main.pl >2. Login as a patron to make self checkouts >3. Check many items out and notice an additional alert is rendered > for each checkout, eventually pushing the barcode input off screen. > >To test: >1. Apply patch and restart_alll >2. Login as a patron to make self checkouts >3. Check many items out >4. Notice only the most recent checkout is rendered as an info alert >5. Confirm the Checkouts table below still loads all checkouts >6. In Admin set BatchCheckouts to 'Allow' >7. Set SCOBatchCheckoutsValidCategories to 'Select all' >8. Login to sco as a patron and enter a newline delimited list of barcodes >9. Confirm that an alert is rendered for each checkout in the batch > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../bootstrap/en/modules/sco/sco-main.tt | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index db9e2822fe..df93ac491f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -214,11 +214,18 @@ > [% END %] > > [% IF ( issued ) %] >- [% FOREACH barcode IN newissues.split(',') %] >- <span class="sco-alert-success issue"></span> >- <div class="alert alert-info"> >- <p>Item checked out <i>([% barcode | html %])</i></p> >- </div> >+ [% IF batch_checkouts_allowed %] >+ [% FOREACH barcode IN newissues.split(',') %] >+ <span class="sco-alert-success issue"></span> >+ <div class="alert alert-info"> >+ <p>Item checked out <i>([% barcode | html %])</i></p> >+ </div> >+ [% END %] >+ [% ELSE %] >+ <span class="sco-alert-success issue"></span> >+ <div class="alert alert-info"> >+ <p>Item checked out <i>([% newissues.split(',').last | html %])</i></p> >+ </div> > [% END %] > [% ELSIF ( renewed ) %] > <span class="sco-alert-success renew"></span> >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38174
:
172774
|
175856
|
176838