Bug 38174 - Self Checkout renders alert for each checkout in session instead of just most recent checkout
Summary: Self Checkout renders alert for each checkout in session instead of just most...
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Brendan Lawlor
QA Contact: Testopia
URL:
Keywords:
Depends on: 32256
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-15 12:18 UTC by Brendan Lawlor
Modified: 2024-10-15 13:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38174: Fix self checkout alerts for non batch checkouts (2.94 KB, patch)
2024-10-15 13:02 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Lawlor 2024-10-15 12:18:44 UTC
In self checkout, if a  patron scans a stack of books one at a time, an additional blue alert-info box is rendered for each new checkout. When this list becomes long it can push the barcode input down so far that it goes off screen which can be confusing for patrons.

When not using batch checkout, self checkout should only render an alert-info box for the most recent scan.
Comment 1 Brendan Lawlor 2024-10-15 13:02:20 UTC
Created attachment 172774 [details] [review]
Bug 38174: Fix self checkout alerts for non batch checkouts

This patch adds a check for batch_checkouts_allowed to SCO.

If not using batch checkout, only the most recent chekout should be
rendered as an alert, instead of all the new issues for the session.

This makes the input box consitently render in the same position.

To replicate:
1. Login as self_checkout to localhost:8080/cgi-bin/koha/sco/sco-main.pl
2. Login as a patron to make self checkouts
3. Check many items out and notice an additional alert is rendered
    for each checkout, eventually pushing the barcode input off screen.

To test:
1. Apply patch and restart_alll
2. Login as a patron to make self checkouts
3. Check many items out
4. Notice only the most recent checkout is rendered as an info alert
5. Confirm the Checkouts table below still loads all checkouts
6. In Admin set BatchCheckouts to 'Allow'
7. Set SCOBatchCheckoutsValidCategories to 'Select all'
8. Login to sco as a patron and enter a newline delimited list of barcodes
9. Confirm that an alert is rendered for each checkout in the batch