Bugzilla – Attachment 176437 Details for
Bug 38870
Remove overflow scroll from batch patron modification
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38870: Remove overflow scroll from batch patron modification
Bug-38870-Remove-overflow-scroll-from-batch-patron.patch (text/plain), 19.19 KB, created by
Owen Leonard
on 2025-01-13 13:34:44 UTC
(
hide
)
Description:
Bug 38870: Remove overflow scroll from batch patron modification
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-01-13 13:34:44 UTC
Size:
19.19 KB
patch
obsolete
>From 831b69e6e3b558fe430a11e8462f7296d258198b Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 13 Jan 2025 12:59:36 +0000 >Subject: [PATCH] Bug 38870: Remove overflow scroll from batch patron > modification > >This patch removes the <div> surrounding batch patron modification >results with the style "overflow:auto". Also removed is the DataTable >option "scrollX". This eliminates the horizontal scrolling for the table >itself, and causes the whole page to scroll horizontally instead. This >is consistent with other pages in Koha. > >This fix lets us avoid bugs which are associated with the overflow >scrolling and our DataTables implementation. (see Bug 37730). > >To test, apply the patch and go to Tools -> Batch patron modification > >- Submit a batch of patrons for modification. >- On the screen showing the patrons which will be modified, the page > will probably have a horizontal scrollbar already. If not, resize your > browser to confirm that the whole page scrolls, not just the table. >- Confirm that the table header "sticks" to the top of the screen when > you scroll down, and that the header continues to be aligned correctly > when you scroll horizontally. > >Sponsored-by: Athens County Public Libraries >--- > .../prog/en/modules/tools/modborrowers.tt | 207 +++++++++--------- > 1 file changed, 102 insertions(+), 105 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >index 476f98b2e4..ed7cd00492 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >@@ -231,124 +231,122 @@ > [% END %] > [% IF borrowers %] > <div id="cataloguing_additem_itemlist" class="page-section"> >- <div style="overflow:auto"> >- <table id="borrowerst"> >- <thead> >+ <table id="borrowerst"> >+ <thead> >+ <tr> >+ [% IF ( op == 'show' ) %] >+ <th class="NoSort"> </th> >+ [% ELSE %] >+ <th class="NoVisible"> </th> >+ [% END %] >+ <th>Card number</th> >+ <th>Surname</th> >+ <th>First name</th> >+ <th>Library</th> >+ <th>Patron category</th> >+ <th>Street number</th> >+ <th>Address</th> >+ <th>Address 2</th> >+ <th>City</th> >+ <th>State</th> >+ <th>ZIP/Postal code</th> >+ <th>Country</th> >+ <th>Primary email</th> >+ <th>Primary phone</th> >+ <th>Other phone</th> >+ <th>Fax</th> >+ <th>Registration date</th> >+ <th>Expiry date</th> >+ [% IF CanUpdatePasswordExpiration %] >+ <th>Password expiration date</th> >+ [% END %] >+ [% IF CanUpdateProtectPatron %] >+ <th>Protected</th> >+ [% END %] >+ <th>Circulation note</th> >+ <th>OPAC note</th> >+ <th>Message</th> >+ <th>Restriction expiration</th> >+ <th>Restriction comment</th> >+ [% FOREACH attrh IN attributes_header %] >+ <th>[% attrh.attribute | html %]</th> >+ [% END %] >+ </tr> >+ </thead> >+ <tbody> >+ [% FOREACH borrower IN borrowers %] > <tr> > [% IF ( op == 'show' ) %] >- <th class="NoSort"> </th> >+ <td> > [% ELSE %] >- <th class="NoVisible"> </th> >+ <td class="NoVisible"> > [% END %] >- <th>Card number</th> >- <th>Surname</th> >- <th>First name</th> >- <th>Library</th> >- <th>Patron category</th> >- <th>Street number</th> >- <th>Address</th> >- <th>Address 2</th> >- <th>City</th> >- <th>State</th> >- <th>ZIP/Postal code</th> >- <th>Country</th> >- <th>Primary email</th> >- <th>Primary phone</th> >- <th>Other phone</th> >- <th>Fax</th> >- <th>Registration date</th> >- <th>Expiry date</th> >+ <input type="checkbox" name="borrowernumber" value="[% borrower.borrowernumber | html %]" checked="checked" /> >+ </td> >+ <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrower.borrowernumber | uri %]">[% borrower.cardnumber | html %]</a></td> >+ <td>[% borrower.surname | html %]</td> >+ <td>[% borrower.firstname | html %]</td> >+ <td>[% Branches.GetName( borrower.branchcode ) | html %]</td> >+ <td>[% Categories.GetName(borrower.categorycode) | html %]</td> >+ <td>[% borrower.streetnumber | html %]</td> >+ <td>[% borrower.address | html %]</td> >+ <td>[% borrower.address2 | html %]</td> >+ <td>[% borrower.city | html %]</td> >+ <td>[% borrower.state | html %]</td> >+ <td>[% borrower.zipcode | html %]</td> >+ <td>[% borrower.country | html %]</td> >+ <td>[% borrower.email | html %]</td> >+ <td>[% borrower.phone | html %]</td> >+ <td>[% borrower.mobile | html %]</td> >+ <td>[% borrower.fax | html %]</td> >+ <td data-order="[% borrower.dateenrolled | html %]">[% borrower.dateenrolled | $KohaDates %]</td> >+ <td data-order="[% borrower.dateexpiry | html %]">[% borrower.dateexpiry | $KohaDates %]</td> > [% IF CanUpdatePasswordExpiration %] >- <th>Password expiration date</th> >+ [% IF borrower.password_expiration_date %] >+ <td data-order="[% borrower.password_expiration_date | html %]"> >+ [% borrower.password_expiration_date | $KohaDates %] >+ </td> >+ [% ELSE %] >+ <td data-order="9999-99-99">Never</td> >+ [% END %] > [% END %] > [% IF CanUpdateProtectPatron %] >- <th>Protected</th> >- [% END %] >- <th>Circulation note</th> >- <th>OPAC note</th> >- <th>Message</th> >- <th>Restriction expiration</th> >- <th>Restriction comment</th> >- [% FOREACH attrh IN attributes_header %] >- <th>[% attrh.attribute | html %]</th> >- [% END %] >- </tr> >- </thead> >- <tbody> >- [% FOREACH borrower IN borrowers %] >- <tr> >- [% IF ( op == 'show' ) %] >- <td> >+ <td> >+ [% IF borrower.protected %] >+ Yes > [% ELSE %] >- <td class="NoVisible"> >+ No > [% END %] >- <input type="checkbox" name="borrowernumber" value="[% borrower.borrowernumber | html %]" checked="checked" /> > </td> >- <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrower.borrowernumber | uri %]">[% borrower.cardnumber | html %]</a></td> >- <td>[% borrower.surname | html %]</td> >- <td>[% borrower.firstname | html %]</td> >- <td>[% Branches.GetName( borrower.branchcode ) | html %]</td> >- <td>[% Categories.GetName(borrower.categorycode) | html %]</td> >- <td>[% borrower.streetnumber | html %]</td> >- <td>[% borrower.address | html %]</td> >- <td>[% borrower.address2 | html %]</td> >- <td>[% borrower.city | html %]</td> >- <td>[% borrower.state | html %]</td> >- <td>[% borrower.zipcode | html %]</td> >- <td>[% borrower.country | html %]</td> >- <td>[% borrower.email | html %]</td> >- <td>[% borrower.phone | html %]</td> >- <td>[% borrower.mobile | html %]</td> >- <td>[% borrower.fax | html %]</td> >- <td data-order="[% borrower.dateenrolled | html %]">[% borrower.dateenrolled | $KohaDates %]</td> >- <td data-order="[% borrower.dateexpiry | html %]">[% borrower.dateexpiry | $KohaDates %]</td> >- [% IF CanUpdatePasswordExpiration %] >- [% IF borrower.password_expiration_date %] >- <td data-order="[% borrower.password_expiration_date | html %]"> >- [% borrower.password_expiration_date | $KohaDates %] >- </td> >- [% ELSE %] >- <td data-order="9999-99-99">Never</td> >- [% END %] >- [% END %] >- [% IF CanUpdateProtectPatron %] >- <td> >- [% IF borrower.protected %] >- Yes >+ [% END %] >+ <td>[% borrower.borrowernotes | $raw | html_line_break %]</td> >+ <td>[% borrower.opacnote | html %]</td> >+ <td> >+ [% FOREACH patron_message IN borrower.patron_messages %] >+ [% patron_message.message | html %] <br> >+ <strong> >+ [% IF (patron_message.message_type == 'B') %] >+ ( OPAC ) > [% ELSE %] >- No >+ ( Staff ) > [% END %] >- </td> >+ </strong><br><br> > [% END %] >- <td>[% borrower.borrowernotes | $raw | html_line_break %]</td> >- <td>[% borrower.opacnote | html %]</td> >- <td> >- [% FOREACH patron_message IN borrower.patron_messages %] >- [% patron_message.message | html %] <br> >- <strong> >- [% IF (patron_message.message_type == 'B') %] >- ( OPAC ) >- [% ELSE %] >- ( Staff ) >- [% END %] >- </strong><br><br> >- [% END %] >- </td> >- <td data-order="[% borrower.debarred | html %]">[% borrower.debarred | $KohaDates %]</td> >- <td>[% borrower.debarredcomment | html %]</td> >- [% FOREACH pa IN borrower.patron_attributes %] >- [% IF ( pa.code ) %] >- [%# Replace pa.attribute with pa.description if we prefer to display the description %] >- <td>[% pa.code | html %]=[% pa.attribute | html %]</td> >- [% ELSE %] >- <td></td> >- [% END %] >+ </td> >+ <td data-order="[% borrower.debarred | html %]">[% borrower.debarred | $KohaDates %]</td> >+ <td>[% borrower.debarredcomment | html %]</td> >+ [% FOREACH pa IN borrower.patron_attributes %] >+ [% IF ( pa.code ) %] >+ [%# Replace pa.attribute with pa.description if we prefer to display the description %] >+ <td>[% pa.code | html %]=[% pa.attribute | html %]</td> >+ [% ELSE %] >+ <td></td> > [% END %] >- </tr> >- [% END %] >- </tbody> >- </table> >- </div> >+ [% END %] >+ </tr> >+ [% END %] >+ </tbody> >+ </table> > </div> > > [% IF ( op == 'show' ) %] >@@ -507,7 +505,6 @@ > let patron_table = KohaTable("borrowerst", { > "order": [[ 1, "asc" ]], > "autoWidth": true, >- "scrollX": true, > }, table_settings); > > $("#selectallbutton").click(function() { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38870
:
176437
|
176451
|
176947