Bug 38870 - Remove overflow scroll from batch patron modification
Summary: Remove overflow scroll from batch patron modification
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-13 12:59 UTC by Owen Leonard
Modified: 2025-04-22 20:28 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.04
Circulation function:


Attachments
Bug 38870: Remove overflow scroll from batch patron modification (19.19 KB, patch)
2025-01-13 13:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38870: Remove overflow scroll from batch patron modification (19.25 KB, patch)
2025-01-13 14:51 UTC, William Lavoie
Details | Diff | Splinter Review
Bug 38870: Remove overflow scroll from batch patron modification (19.32 KB, patch)
2025-01-23 11:10 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-01-13 12:59:32 UTC
Bug 37730 fixed problems with the batch patron modification DataTable when scrolling horizontally and vertically. Since the DataTables upgrade there are new problems, so I propose we remove the container around the table which has "overflow:auto" and the DataTables option "scrollX".

This will make the page behave like others, where wide tables cause a full page horizontal scroll.
Comment 1 Owen Leonard 2025-01-13 13:34:44 UTC
Created attachment 176437 [details] [review]
Bug 38870: Remove overflow scroll from batch patron modification

This patch removes the <div> surrounding batch patron modification
results with the style "overflow:auto". Also removed is the DataTable
option "scrollX". This eliminates the horizontal scrolling for the table
itself, and causes the whole page to scroll horizontally instead. This
is consistent with other pages in Koha.

This fix lets us avoid bugs which are associated with the overflow
scrolling and our DataTables implementation. (see Bug 37730).

To test, apply the patch and go to Tools -> Batch patron modification

- Submit a batch of patrons for modification.
- On the screen showing the patrons which will be modified, the page
  will probably have a horizontal scrollbar already. If not, resize your
  browser to confirm that the whole page scrolls, not just the table.
- Confirm that the table header "sticks" to the top of the screen when
  you scroll down, and that the header continues to be aligned correctly
  when you scroll horizontally.

Sponsored-by: Athens County Public Libraries
Comment 2 Jonathan Druart 2025-01-13 14:37:24 UTC
scrollX's behaviour is better than this. But at least it's now consistent for all the other tables.

If we want to fix that globally we should investigate a bit better how to fix this problem.

For now I would vote for consistency and +1 Owen's patch.
Comment 3 William Lavoie 2025-01-13 14:51:17 UTC
Created attachment 176451 [details] [review]
Bug 38870: Remove overflow scroll from batch patron modification

This patch removes the <div> surrounding batch patron modification
results with the style "overflow:auto". Also removed is the DataTable
option "scrollX". This eliminates the horizontal scrolling for the table
itself, and causes the whole page to scroll horizontally instead. This
is consistent with other pages in Koha.

This fix lets us avoid bugs which are associated with the overflow
scrolling and our DataTables implementation. (see Bug 37730).

To test, apply the patch and go to Tools -> Batch patron modification

- Submit a batch of patrons for modification.
- On the screen showing the patrons which will be modified, the page
  will probably have a horizontal scrollbar already. If not, resize your
  browser to confirm that the whole page scrolls, not just the table.
- Confirm that the table header "sticks" to the top of the screen when
  you scroll down, and that the header continues to be aligned correctly
  when you scroll horizontally.

Sponsored-by: Athens County Public Libraries
Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Comment 4 Jonathan Druart 2025-01-23 11:10:00 UTC
Created attachment 176947 [details] [review]
Bug 38870: Remove overflow scroll from batch patron modification

This patch removes the <div> surrounding batch patron modification
results with the style "overflow:auto". Also removed is the DataTable
option "scrollX". This eliminates the horizontal scrolling for the table
itself, and causes the whole page to scroll horizontally instead. This
is consistent with other pages in Koha.

This fix lets us avoid bugs which are associated with the overflow
scrolling and our DataTables implementation. (see Bug 37730).

To test, apply the patch and go to Tools -> Batch patron modification

- Submit a batch of patrons for modification.
- On the screen showing the patrons which will be modified, the page
  will probably have a horizontal scrollbar already. If not, resize your
  browser to confirm that the whole page scrolls, not just the table.
- Confirm that the table header "sticks" to the top of the screen when
  you scroll down, and that the header continues to be aligned correctly
  when you scroll horizontally.

Sponsored-by: Athens County Public Libraries
Signed-off-by: William Lavoie <william.lavoie@inLibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2025-01-23 11:10:09 UTC
We didn't get feedback from the people involved on bug 37730 so I am passing QA on this.
Comment 6 Katrin Fischer 2025-01-24 11:03:38 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Paul Derscheid 2025-04-22 20:28:00 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.04