Bugzilla – Attachment 176473 Details for
Bug 38872
Only first 'a' node tested for wrong filters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38872: Parse all 'a' element, not only the first one
Bug-38872-Parse-all-a-element-not-only-the-first-o.patch (text/plain), 1.22 KB, created by
David Nind
on 2025-01-13 20:23:48 UTC
(
hide
)
Description:
Bug 38872: Parse all 'a' element, not only the first one
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-01-13 20:23:48 UTC
Size:
1.22 KB
patch
obsolete
>From eed4d0c10a31d32ccc316e7a7a5d80d2fdf451bd Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 13 Jan 2025 14:40:40 +0100 >Subject: [PATCH] Bug 38872: Parse all 'a' element, not only the first one > >Test plan: >Apply the "Add test" commit >% prove t/template_filters.t >=> Fail >Apply this patch >% prove t/template_filters.t >=> Success >% prove xt/find-missing-filters.t >=> Fail >Apply the last patch "Fix occurrences" >% prove xt/find-missing-filters.t >=> Success > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: David Nind <david@davidnind.com> >--- > t/lib/QA/TemplateFilters.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/lib/QA/TemplateFilters.pm b/t/lib/QA/TemplateFilters.pm >index 86aa034df3..4f3825fbcc 100644 >--- a/t/lib/QA/TemplateFilters.pm >+++ b/t/lib/QA/TemplateFilters.pm >@@ -77,7 +77,7 @@ sub _process_tt_content { > if $line =~ m{\[%(\s|-|~)*USE raw(\s|-|~)*%\]}; # Does [% Use raw %] exist? > > my $e; >- if ( $line =~ qr{<a href="([^"]+)} ) { >+ while ( $line =~ m{<a href="([^"]+)}g ) { > my $to_uri_escape = $1; > while ( > $to_uri_escape =~ m{ >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38872
:
176443
|
176444
|
176445
|
176446
|
176447
|
176448
|
176472
|
176473
|
176474
|
176778
|
176779
|
176780