If several 'a' elements are on the same line, only the first one will be tested for wrong filters.
Created attachment 176443 [details] [review] Bug 38872: Add a test
Created attachment 176444 [details] [review] Bug 38872: Parse all 'a' element, not only the first one Test plan: Apply the "Add test" commit % prove t/template_filters.t => Fail Apply this patch % prove t/template_filters.t => Success % prove xt/find-missing-filters.t => Fail Apply the last patch "Fix occurrences" % prove xt/find-missing-filters.t => Success
Created attachment 176445 [details] [review] Bug 38872: Fix the missing occurrences
Created attachment 176446 [details] [review] Bug 38872: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 176447 [details] [review] Bug 38872: Parse all 'a' element, not only the first one Test plan: Apply the "Add test" commit % prove t/template_filters.t => Fail Apply this patch % prove t/template_filters.t => Success % prove xt/find-missing-filters.t => Fail Apply the last patch "Fix occurrences" % prove xt/find-missing-filters.t => Success Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 176448 [details] [review] Bug 38872: Fix the missing occurrences Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 176472 [details] [review] Bug 38872: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176473 [details] [review] Bug 38872: Parse all 'a' element, not only the first one Test plan: Apply the "Add test" commit % prove t/template_filters.t => Fail Apply this patch % prove t/template_filters.t => Success % prove xt/find-missing-filters.t => Fail Apply the last patch "Fix occurrences" % prove xt/find-missing-filters.t => Success Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176474 [details] [review] Bug 38872: Fix the missing occurrences Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>
Added my sign off, in case Owen's can count as QA. Results of running the QA script: qa testing 3 commit(s) (applied to 3fc855f '68 Bug 38856: Typo: EmailAddressForPa') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 260. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. |========================>| 6 / 6 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 260. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. |========================>| 6 / 6 (100.00%) OK koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt OK t/lib/QA/TemplateFilters.pm WARN t/template_filters.t WARN tidiness The file is less tidy than before (bad/messy lines before: 17, now: 19)
Created attachment 176778 [details] [review] Bug 38872: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 176779 [details] [review] Bug 38872: Parse all 'a' element, not only the first one Test plan: Apply the "Add test" commit % prove t/template_filters.t => Fail Apply this patch % prove t/template_filters.t => Success % prove xt/find-missing-filters.t => Fail Apply the last patch "Fix occurrences" % prove xt/find-missing-filters.t => Success Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 176780 [details] [review] Bug 38872: Fix the missing occurrences Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.04