Attachment 17665 Details for Bug 10107 – PASSED-QA-Bug-10107-opacbookbag-shouldn-t-prevent...

[patch] PASSED-QA-Bug-10107-opacbookbag-shouldn-t-prevent...

0001-PASSED-QA-Bug-10107-opacbookbag-shouldn-t-prevent-fr.patch (text/plain), 2.00 KB, created by Katrin Fischer on 2013-04-25 06:21:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-04-25 06:21:09 UTC

Size: 2.00 KB

patch

obsolete

>From 1cc39cff5769dd651408f90e04e5022c2ba704ef Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Wed, 24 Apr 2013 11:40:18 -0300
>Subject: [PATCH] [PASSED QA] Bug 10107 - opacbookbag shouldn't prevent from
> adding items to a list in the OPAC
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This bug is present in master and (at least 3.8.x, where we spotted it).
>The patch makes adding items, to a list from the results page, not rely
>only on opacbookbag syspref but also 'virtualshelves'.
>
>Regards
>To+
>
>PS: Thanks Graciela Galli for reporting.
>
>Sponsored-by: Universidad Nacional de CÃ³rdoba
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Template only patch, works nicely.
>Test plan copied from bug report:
>
>- Disable the opacbookbag syspref
>- Login in the OPAC
>- Create a list (I tested a private one)
>- Search in your db for some biblios.
>- Choose some and add them to the created list
>- Go to your users's page, to the my lists tab
>- Your list is empty.
>---
> .../opac-tmpl/prog/en/modules/opac-results.tt      |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>index 192fab0..0704f06 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>@@ -186,7 +186,7 @@ $(document).ready(function(){
>     $("span.clearall").html("<a id=\"CheckNone\" href=\"#\">"+_("Clear all")+"<\/a>");
>     $("span.checkall").html("<a id=\"CheckAll\" href=\"#\">"+_("Select all")+"<\/a>");
> [% IF ( opacbookbag ) %]$("span.addto").html(param1);[% ELSE %][% IF ( virtualshelves ) %][% IF ( loggedinusername ) %]$("span.addto").html(param1);[% END %][% END %][% END %]
>-[% IF ( opacbookbag ) %]
>+[% IF ( opacbookbag || virtualshelves ) %]
>     [% IF ( virtualshelves ) %]
>     $("#addto").change(function(){
>         cartList();
>-- 
>1.7.9.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 10107: 17656 | 17659 | 17665 | 17675 | 17729