Bugzilla – Attachment 17690 Details for
Bug 2046
Suggestions: Title Field too small
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch
0001-Bug-2046-Increase-title-field-length.patch (text/plain), 4.84 KB, created by
Kristina Hoeppner
on 2013-04-26 04:31:33 UTC
(
hide
)
Description:
proposed patch
Filename:
MIME Type:
Creator:
Kristina Hoeppner
Created:
2013-04-26 04:31:33 UTC
Size:
4.84 KB
patch
obsolete
>From 4ed03c114090cb95cb0fc3820a8daf270467279e Mon Sep 17 00:00:00 2001 >From: "Kristina D.C. Hoeppner" <kristina@catalyst.net.nz> >Date: Fri, 29 Mar 2013 15:04:42 +1300 >Subject: [PATCH] Bug 2046: Increase title field length > >Increase both on staff and OPAC interface >from 80 to 255 characters to be saved in >the database. Shown will be 80 characters. >--- > installer/data/mysql/kohastructure.sql | 2 +- > installer/data/mysql/updatedatabase.pl | 7 +++++++ > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- > koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt | 2 +- > 4 files changed, 10 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 24097ed..34a4cec 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1969,7 +1969,7 @@ CREATE TABLE `suggestions` ( -- purchase suggestions > `STATUS` varchar(10) NOT NULL default '', -- suggestion status (ASKED, CHECKED, ACCEPTED, or REJECTED) > `note` mediumtext, -- note entered on the suggestion > `author` varchar(80) default NULL, -- author of the suggested item >- `title` varchar(80) default NULL, -- title of the suggested item >+ `title` varchar(255) default NULL, -- title of the suggested item > `copyrightdate` smallint(6) default NULL, -- copyright date of the suggested item > `publishercode` varchar(255) default NULL, -- publisher of the suggested item > `date` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time the suggestion was updated >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 7c97a51..18703d2 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -6771,6 +6771,13 @@ if ( CheckVersion($DBversion) ) { > SetVersion ($DBversion); > } > >+$DBversion = "XXX"; >+if ( CheckVersion($DBversion) ) { >+ $dbh->do(q{ALTER TABLE suggestions CHANGE COLUMN title title VARCHAR(255) DEFAULT NULL;}); >+ print "Upgrade to $DBversion done (Bug 2046 - increasing title column length for suggestions)\n"; >+ SetVersion ($DBversion); >+} >+ > > =head1 FUNCTIONS > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index bd855bf..e8f0679 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -267,7 +267,7 @@ $(document).ready(function() { calcNewsuggTotal(); }); > <h1>Enter a new purchase suggestion</h1> > [% END %] > <fieldset class="rows"> <legend>Bibliographic information</legend><ol> >- <li><label for="title">Title:</label><input type="text" id="title" name="title" size="50" maxlength="80" value="[% title |html %]"/></li> >+ <li><label for="title">Title:</label><input type="text" id="title" name="title" size="80" maxlength="255" value="[% title |html %]"/></li> > <li><label for="author">Author:</label><input type="text" id="author" name="author" size="50" maxlength="80" value="[% author %]"/></li> > <li><label for="copyrightdate">Copyright date:</label><input type="text" id="copyrightdate" name="copyrightdate" size="4" maxlength="4" value="[% copyrightdate %]" /></li> > <li><label for="isbn">ISBN or ISSN or other standard number:</label><input type="text" id="isbn" name="isbn" size="50" maxlength="80" value="[% isbn %]"/></li> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt >index 65cb297..51f898c 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt >@@ -103,7 +103,7 @@ $.tablesorter.addParser({ > <p>Only the title is required, but the more information you enter the easier it will be for the librarians to find the title you're requesting. The "Notes" field can be used to provide any additional information.</p> > <form action="/cgi-bin/koha/opac-suggestions.pl" method="post"> > <fieldset class="rows"> <ol> >- <li><label class="required" for="title">Title:</label><input type="text" id="title" name="title" size="50" maxlength="80" /></li> >+ <li><label class="required" for="title">Title:</label><input type="text" id="title" name="title" size="80" maxlength="255" /></li> > <li><label for="author">Author:</label><input type="text" id="author" name="author" size="50" maxlength="80" /></li> > <li><label for="copyrightdate">Copyright Date:</label><input type="text" id="copyrightdate" name="copyrightdate" size="4" maxlength="4" /></li> > <li><label for="isbn">Standard Number (ISBN, ISSN or Other):</label><input type="text" id="isbn" name="isbn" size="50" maxlength="80" /></li> >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2046
:
463
|
464
|
17690
|
17724
|
17747
|
17748