Bugzilla – Attachment 177073 Details for
Bug 38954
checkout type column should be hidden by colvis
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38954: Hide checkout type using colvis
Bug-38954-Hide-checkout-type-using-colvis.patch (text/plain), 2.50 KB, created by
David Nind
on 2025-01-23 19:54:44 UTC
(
hide
)
Description:
Bug 38954: Hide checkout type using colvis
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-01-23 19:54:44 UTC
Size:
2.50 KB
patch
obsolete
>From 5f25083eee9b587202faf8c4cd89fb6326160b56 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 Jan 2025 12:05:02 +0100 >Subject: [PATCH] Bug 38954: Hide checkout type using colvis > >This is not the correct way to hide a column, we should use the DT's column >visibility plugin. > >Test plan: >Have some checkouts for a patron, go to the checkout history page >Without this patch notice the "shift" => the table does not take the >whole available width. > >Apply this patch, restart_all, remove localStorage entries > >=> The table is now displayed properly > >You can also play with on-site checkouts. > >Before: >https://snipboard.io/uTWYit.jpg >https://snipboard.io/qxZE35.jpg > >After: >https://snipboard.io/2L0F3Q.jpg >Signed-off-by: David Nind <david@davidnind.com> >--- > admin/columns_settings.yml | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index f0f50415fa..2a632acc25 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -1420,6 +1420,7 @@ modules: > - columnname: type > cannot_be_toggled: 1 > cannot_be_modified: 1 >+ is_hidden: 1 > - > columnname: date > - >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >index 8558bd2ad1..de899d726e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >@@ -62,7 +62,7 @@ > <table id="table_readingrec"> > <thead> > <tr> >- <th style="display:none;">Type</th> >+ <th>Type</th> > <th>Date</th> > <th class="anti-the">Title</th> > <th>Author</th> >@@ -84,7 +84,7 @@ > [% SET item = checkout.item %] > [% SET biblio = item.biblio %] > <tr> >- <td style="display:none;"> >+ <td> > [% IF checkout.onsite_checkout %][% issuetype = 'onsite_checkout' | html %] > [% ELSE %][% issuetype = 'standard_checkout' | html %] > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38954
:
176946
|
177073
|
177075
|
177100