There is a "shift" in the checkout history table (readingrec) https://snipboard.io/uTWYit.jpg https://snipboard.io/qxZE35.jpg The table should take the whole available width
Created attachment 176946 [details] [review] Bug 38954: Hide checkout type using colvis This is not the correct way to hide a column, we should use the DT's column visibility plugin. Test plan: Have some checkouts for a patron, go to the checkout history page Without this patch notice the "shift" => the table does not take the whole available width. Apply this patch, restart_all, remove localStorage entries => The table is now displayed properly You can also play with on-site checkouts. Before: https://snipboard.io/uTWYit.jpg https://snipboard.io/qxZE35.jpg After: https://snipboard.io/2L0F3Q.jpg
Created attachment 177073 [details] [review] Bug 38954: Hide checkout type using colvis This is not the correct way to hide a column, we should use the DT's column visibility plugin. Test plan: Have some checkouts for a patron, go to the checkout history page Without this patch notice the "shift" => the table does not take the whole available width. Apply this patch, restart_all, remove localStorage entries => The table is now displayed properly You can also play with on-site checkouts. Before: https://snipboard.io/uTWYit.jpg https://snipboard.io/qxZE35.jpg After: https://snipboard.io/2L0F3Q.jpg Signed-off-by: David Nind <david@davidnind.com>
Created attachment 177075 [details] Screenshot - Type column value is system value, not a human-readable value I've signed off, but I had to apply bug 38783 first, otherwise I got a sha1/fake ancestor error. I've added it as a dependency. Also, there is now a new "Type" column displayed by default. For normal checkouts, the value shown is "standard_checkout" (see the screenshot). Shouldn't this display as a "human-readable" value, rather than a system value? Such as "Standard checkout", and for other types of checkouts (which I didn't test). I do really like the improved layout and the pill "button", it is very much improved!
You should not see the "Type" column. Did you restart_all after you applied the patches? Also maybe you need to remove your localStorage entries.
(In reply to Jonathan Druart from comment #4) > You should not see the "Type" column. Did you restart_all after you applied > the patches? Also maybe you need to remove your localStorage entries. Apologies for the noise - that was it! Now working as expected. (I normally start with a fresh browser with a cleared cache after applying a patch. For some reason, I forgot to do this...)
Created attachment 177100 [details] [review] Bug 38954: Hide checkout type using colvis This is not the correct way to hide a column, we should use the DT's column visibility plugin. Test plan: Have some checkouts for a patron, go to the checkout history page Without this patch notice the "shift" => the table does not take the whole available width. Apply this patch, restart_all, remove localStorage entries => The table is now displayed properly You can also play with on-site checkouts. Before: https://snipboard.io/uTWYit.jpg https://snipboard.io/qxZE35.jpg After: https://snipboard.io/2L0F3Q.jpg Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!