Bugzilla – Attachment 177358 Details for
Bug 38964
Fix column span in footer of staff interface account payment page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38964: Fix column span in footer of staff interface account payment page
Bug-38964-Fix-column-span-in-footer-of-staff-inter.patch (text/plain), 3.43 KB, created by
Lucas Gass (lukeg)
on 2025-01-30 18:13:09 UTC
(
hide
)
Description:
Bug 38964: Fix column span in footer of staff interface account payment page
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-01-30 18:13:09 UTC
Size:
3.43 KB
patch
obsolete
>From 2e457782fc2fe57482a6396af633036c0fa434e2 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 24 Jan 2025 15:58:32 +0000 >Subject: [PATCH] Bug 38964: Fix column span in footer of staff interface > account payment page > >This patch fixes the column span in the table footer rows of the account >payment page (pay.tt). I've also added a couple of lines of CSS to style >the footer rows. > >To test, apply the patch and rebuild the staff interface CSS. > >- In the staff client, locate a patron with charges. >- If necessary, go to a patrons "Accounting" tab and use the "Create > manual invoice" page to add one or more charges to the account. >- Under the "Make a payment" tab there should be one or more footer rows > including "Total due." The "Total due" cell should be aligned right, > with a grey background. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss | 7 +++++++ > .../intranet-tmpl/prog/en/modules/members/pay.tt | 12 ++++++++---- > 2 files changed, 15 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >index c3d1297bff2..ae6839e02fc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >@@ -95,6 +95,13 @@ table { > th { > padding: .5em; > } >+ >+ & > tr { >+ & th[scope="row"] { >+ background-color: $table-odd-row; >+ text-align: right; >+ } >+ } > } > > thead { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >index 3510d207b26..c4ab9855834 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >@@ -179,16 +179,20 @@ > > <tfoot> > <tr> >- <td class="total" colspan="12">Total due:</td> >+ <th scope="row" class="total" colspan="14">Total due:</th> > <td style="text-align: right;">[% total | $Price %]</td> > </tr> > [% IF outstanding_credits.total_outstanding < 0 %] > <tr> >- <td class="total" colspan="12">Outstanding credits could be applied: </td> >- <td class="credit" style="text-align: right;"><button type="submit" id="apply_credits" name="op" value="cud-apply_credits" class="btn btn-default btn-sm">Apply <strong class="credit">[% outstanding_credits.total_outstanding | $Price %]</strong></button></td> >+ <th scope="row" class="total" colspan="14">Outstanding credits could be applied: </th> >+ <td class="credit" style="text-align: right;" >+ ><button type="submit" id="apply_credits" name="op" value="cud-apply_credits" class="btn btn-default btn-sm" >+ >Apply <strong class="credit">[% outstanding_credits.total_outstanding | $Price %]</strong></button >+ ></td >+ > > </tr> > <tr> >- <td class="total" colspan="12">Total due if credit applied:</td> >+ <th scope="row" class="total" colspan="14">Total due if credit applied:</th> > <td style="text-align: right;">[% total + outstanding_credits.total_outstanding | $Price %]</td> > </tr> > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38964
:
177128
|
177129
| 177358