Bug 38964 - Fix column span in footer of staff interface account payment page
Summary: Fix column span in footer of staff interface account payment page
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 33137
Blocks:
  Show dependency treegraph
 
Reported: 2025-01-24 16:08 UTC by Owen Leonard
Modified: 2025-04-08 20:12 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes an alignment problem on the 'Make a payment' screen where the table footer had an inconsistent number of columns.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38964: Fix column span in footer of staff interface account payment page (3.52 KB, patch)
2025-01-24 16:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38964: Fix column span in footer of staff interface account payment page (3.37 KB, patch)
2025-01-24 17:39 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 38964: Fix column span in footer of staff interface account payment page (3.43 KB, patch)
2025-01-30 18:13 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-01-24 16:08:53 UTC
The footer of the table of charges on the account payment page has incorrect column spans, resulting in the rows having incorrect alignment.
Comment 1 Owen Leonard 2025-01-24 16:20:18 UTC
Created attachment 177128 [details] [review]
Bug 38964: Fix column span in footer of staff interface account payment page

This patch fixes the column span in the table footer rows of the account
payment page (pay.tt). I've also added a couple of lines of CSS to style
the footer rows.

To test, apply the patch and rebuild the staff interface CSS.

- In the staff client, locate a patron with charges.
- If necessary, go to a patrons "Accounting" tab and use the "Create
  manual invoice" page to add one or more charges to the account.
- Under the "Make a payment" tab there should be one or more footer rows
  including "Total due." The "Total due" cell should be aligned right,
  with a grey background.

Sponsored-by: Athens County Public Libraries
Comment 2 Phil Ringnalda 2025-01-24 17:39:28 UTC
Created attachment 177129 [details] [review]
Bug 38964: Fix column span in footer of staff interface account payment page

This patch fixes the column span in the table footer rows of the account
payment page (pay.tt). I've also added a couple of lines of CSS to style
the footer rows.

To test, apply the patch and rebuild the staff interface CSS.

- In the staff client, locate a patron with charges.
- If necessary, go to a patrons "Accounting" tab and use the "Create
  manual invoice" page to add one or more charges to the account.
- Under the "Make a payment" tab there should be one or more footer rows
  including "Total due." The "Total due" cell should be aligned right,
  with a grey background.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Lucas Gass (lukeg) 2025-01-30 18:13:09 UTC
Created attachment 177358 [details] [review]
Bug 38964: Fix column span in footer of staff interface account payment page

This patch fixes the column span in the table footer rows of the account
payment page (pay.tt). I've also added a couple of lines of CSS to style
the footer rows.

To test, apply the patch and rebuild the staff interface CSS.

- In the staff client, locate a patron with charges.
- If necessary, go to a patrons "Accounting" tab and use the "Create
  manual invoice" page to add one or more charges to the account.
- Under the "Make a payment" tab there should be one or more footer rows
  including "Total due." The "Total due" cell should be aligned right,
  with a grey background.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2025-01-31 14:58:14 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Aude Charillon 2025-03-26 17:43:57 UTC
I believe this is also an issue in versions 24.11 and 23.11: when the Payment note column is hidden, the Total due value disappears.