The footer of the table of charges on the account payment page has incorrect column spans, resulting in the rows having incorrect alignment.
Created attachment 177128 [details] [review] Bug 38964: Fix column span in footer of staff interface account payment page This patch fixes the column span in the table footer rows of the account payment page (pay.tt). I've also added a couple of lines of CSS to style the footer rows. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, locate a patron with charges. - If necessary, go to a patrons "Accounting" tab and use the "Create manual invoice" page to add one or more charges to the account. - Under the "Make a payment" tab there should be one or more footer rows including "Total due." The "Total due" cell should be aligned right, with a grey background. Sponsored-by: Athens County Public Libraries
Created attachment 177129 [details] [review] Bug 38964: Fix column span in footer of staff interface account payment page This patch fixes the column span in the table footer rows of the account payment page (pay.tt). I've also added a couple of lines of CSS to style the footer rows. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, locate a patron with charges. - If necessary, go to a patrons "Accounting" tab and use the "Create manual invoice" page to add one or more charges to the account. - Under the "Make a payment" tab there should be one or more footer rows including "Total due." The "Total due" cell should be aligned right, with a grey background. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 177358 [details] [review] Bug 38964: Fix column span in footer of staff interface account payment page This patch fixes the column span in the table footer rows of the account payment page (pay.tt). I've also added a couple of lines of CSS to style the footer rows. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, locate a patron with charges. - If necessary, go to a patrons "Accounting" tab and use the "Create manual invoice" page to add one or more charges to the account. - Under the "Make a payment" tab there should be one or more footer rows including "Total due." The "Total due" cell should be aligned right, with a grey background. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 25.05! Well done everyone, thank you!
I believe this is also an issue in versions 24.11 and 23.11: when the Payment note column is hidden, the Total due value disappears.