Bugzilla – Attachment 177826 Details for
Bug 38664
Tidy the whole codebase
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38664: Fix updatedatabase.pl
Bug-38664-Fix-updatedatabasepl.patch (text/plain), 1.53 KB, created by
Jonathan Druart
on 2025-02-12 05:40:36 UTC
(
hide
)
Description:
Bug 38664: Fix updatedatabase.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-02-12 05:40:36 UTC
Size:
1.53 KB
patch
obsolete
>From 60c71484bab5e4f3e2941fd0468003026b36666f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 12 Feb 2025 06:37:06 +0100 >Subject: [PATCH] Bug 38664: Fix updatedatabase.pl > >This patch fixes the following error: >sort (...) interpreted as function at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 25950. > >sort @words and sort { $a cmp $b } @words are functionally identical because >Perl's default sort behavior is string-wise ascending order (which is exactly >what { $a cmp $b } specifies). >--- > installer/data/mysql/updatedatabase.pl | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 33e645e0a40..adbd5e4c508 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -25947,8 +25947,10 @@ if ( CheckVersion($DBversion) ) { > |, { Slice => {} } > ); > for my $suggestion (@$suggestions) { >- my ($max_date) = sort ( $suggestion->{manageddate} || (), $suggestion->{accepteddate} || (), >- $suggestion->{rejecteddate} || () ); >+ my ($max_date) = sort { $a cmp $b } ( >+ $suggestion->{manageddate} || (), $suggestion->{accepteddate} || (), >+ $suggestion->{rejecteddate} || () >+ ); > next unless $max_date; > my $last_modif_by = > ( defined $suggestion->{manageddate} and $max_date eq $suggestion->{manageddate} ) >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38664
:
175488
|
175664
|
177755
|
177796
|
177797
|
177798
|
177799
|
177800
|
177801
|
177802
|
177813
|
177825
| 177826 |
177827