Bugzilla – Attachment 178445 Details for
Bug 39124
In lists dropdown, the option "view all" is always displayed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39124: In lists dropdown, the option "view all" is always displayed
Bug-39124-In-lists-dropdown-the-option-view-all-is.patch (text/plain), 2.87 KB, created by
Marcel de Rooy
on 2025-02-21 07:35:01 UTC
(
hide
)
Description:
Bug 39124: In lists dropdown, the option "view all" is always displayed
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-02-21 07:35:01 UTC
Size:
2.87 KB
patch
obsolete
>From c98698a87e93ab91289036b55b06433f6a1a05ac Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Thu, 13 Feb 2025 12:15:42 +0100 >Subject: [PATCH] Bug 39124: In lists dropdown, the option "view all" is always > displayed >Content-Type: text/plain; charset=utf-8 > >In the code of the OPAC, the "Lists" dropdown menu is supposed to >display max. 10 lists and display a button "view all" if there are more >than 10 lists. > >The button "view all" is always displayed and it is weird when there >are few lists because "Public lists" and "Your lists" do the same. > >Test plan: >1 - On an OPAC with less than 10 public lists and 10 private lists, > navigate to /cgi-bin/koha/opac-shelves.pl, click on the dropdown see > there is a view all button for both types of lists >2 - APPLY PATCH >3 - Repeat 1, notice the buttons disappeared >4 - Create lists so there are >10 public and >10 private lists >5 - Repeat 1, notice the buttons reappeared > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index e624134bf5..c35a949dd1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -73,7 +73,7 @@ > [% SET number_of_public_shelves = number_of_public_shelves + 1 %] > [% IF number_of_public_shelves >= 10 %][% LAST %][% END %] > [% END %] >- [% IF some_public_shelves > 10 %] >+ [% IF some_public_shelves.count > 10 %] > <a class="dropdown-item listmenulink" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=1" tabindex="-1" role="menuitem">View all</a> > [% END %] > [% END %] >@@ -92,7 +92,7 @@ > [% SET number_of_private_shelves = number_of_private_shelves + 1 %] > [% IF number_of_private_shelves >= 10 %][% LAST %][% END %] > [% END %] >- [% IF some_private_shelves > 10 %] >+ [% IF some_private_shelves.count > 10 %] > <a class="dropdown-item listmenulink" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=0" tabindex="-1" role="menuitem">View all</a> > [% END %] > [% ELSE %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39124
:
177990
|
178096
| 178445