Bug 39124 - In lists dropdown, the option "view all" is always displayed
Summary: In lists dropdown, the option "view all" is always displayed
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-13 11:15 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-02-21 15:45 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39124: In lists dropdown, the option "view all" is always displayed (2.72 KB, patch)
2025-02-13 11:23 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 39124: In lists dropdown, the option "view all" is always displayed (2.77 KB, patch)
2025-02-14 14:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39124: In lists dropdown, the option "view all" is always displayed (2.87 KB, patch)
2025-02-21 07:35 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2025-02-13 11:15:13 UTC
In the code of the OPAC, the "Lists" dropdown menu is supposed to display max. 10 lists and display a button "view all" if there are more than 10 lists.

The button "view all" is always displayed and it is weird when there are few lists because "Public lists" and "Your lists" do the same.
Comment 1 Baptiste Wojtkowski (bwoj) 2025-02-13 11:23:11 UTC
Created attachment 177990 [details] [review]
Bug 39124: In lists dropdown, the option "view all" is always displayed

In the code of the OPAC, the "Lists" dropdown menu is supposed to display max. 10 lists and display a button "view all" if there are more than 10 lists.

The button "view all" is always displayed and it is weird when there are few lists because "Public lists" and "Your lists" do the same.

Test plan:
1 - On an OPAC with less than 10 public lists and 10 private lists,
  navigate to /cgi-bin/koha/opac-shelves.pl, click on the dropdown see
  there is a view all button for both types of lists
2 - APPLY PATCH
3 - Repeat 1, notice the buttons disappeared
4 - Create lists so there are >10 public and >10 private lists
5 - Repeat 1, notice the buttons reappeared
Comment 2 Owen Leonard 2025-02-14 14:36:03 UTC
Created attachment 178096 [details] [review]
Bug 39124: In lists dropdown, the option "view all" is always displayed

In the code of the OPAC, the "Lists" dropdown menu is supposed to
display max. 10 lists and display a button "view all" if there are more
than 10 lists.

The button "view all" is always displayed and it is weird when there
are few lists because "Public lists" and "Your lists" do the same.

Test plan:
1 - On an OPAC with less than 10 public lists and 10 private lists,
    navigate to /cgi-bin/koha/opac-shelves.pl, click on the dropdown see
    there is a view all button for both types of lists
2 - APPLY PATCH
3 - Repeat 1, notice the buttons disappeared
4 - Create lists so there are >10 public and >10 private lists
5 - Repeat 1, notice the buttons reappeared

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2025-02-21 07:35:01 UTC
Created attachment 178445 [details] [review]
Bug 39124: In lists dropdown, the option "view all" is always displayed

In the code of the OPAC, the "Lists" dropdown menu is supposed to
display max. 10 lists and display a button "view all" if there are more
than 10 lists.

The button "view all" is always displayed and it is weird when there
are few lists because "Public lists" and "Your lists" do the same.

Test plan:
1 - On an OPAC with less than 10 public lists and 10 private lists,
    navigate to /cgi-bin/koha/opac-shelves.pl, click on the dropdown see
    there is a view all button for both types of lists
2 - APPLY PATCH
3 - Repeat 1, notice the buttons disappeared
4 - Create lists so there are >10 public and >10 private lists
5 - Repeat 1, notice the buttons reappeared

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2025-02-21 15:45:04 UTC
Pushed for 25.05!

Well done everyone, thank you!