Bugzilla – Attachment 178529 Details for
Bug 26553
Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26553: Fix incorrect occurrences of 'sortable' => 'orderable'
Bug-26553-Fix-incorrect-occurrences-of-sortable--o.patch (text/plain), 14.43 KB, created by
Martin Renvoize (ashimema)
on 2025-02-21 16:31:07 UTC
(
hide
)
Description:
Bug 26553: Fix incorrect occurrences of 'sortable' => 'orderable'
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-02-21 16:31:07 UTC
Size:
14.43 KB
patch
obsolete
>From b79269002fefa3966322a19d9518bfe1d26ea07e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 28 Jan 2025 10:35:18 +0100 >Subject: [PATCH] Bug 26553: Fix incorrect occurrences of 'sortable' => > 'orderable' > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt | 4 ++-- > .../prog/en/modules/admin/auth_subfields_structure.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt | 2 +- > .../intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt | 2 +- > .../prog/en/modules/patron_lists/patron-lists-tab.tt | 2 +- > .../prog/en/modules/tools/additional-contents.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-search-history.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +- > 17 files changed, 18 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt >index c46aecc128e..153d0e8d90d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt >@@ -435,7 +435,7 @@ > [% ELSE %] > grouped = $("#grouped").kohaTable({ > dom: "t", >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > autoWidth: false, > language: { > emptyTable: _("There are no baskets in this group"), >@@ -443,7 +443,7 @@ > }); > ungrouped = $("#ungrouped").kohaTable({ > dom: "t", >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > autoWidth: false, > language: { > emptyTable: _("There are no ungrouped baskets"), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >index c70e790a6bc..d712da9c598 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >@@ -438,7 +438,7 @@ > <script> > $(document).ready(function() { > $("#table_authsubfieldstructure").kohaTable({ >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > aaSorting: [], > paginate: false, > }); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt >index bb8f2e1f2b3..2fae79bbd29 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt >@@ -200,7 +200,7 @@ > > var table = $("#localization").kohaTable({ > dom: "t", >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > paginate: false, > autoWidth: false, > }); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt >index 96da4bddb5d..e62f8fcc65a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt >@@ -213,7 +213,7 @@ > [% ELSE %] > $(document).ready(function() { > $("#serverst").kohaTable({ >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > pagingType: "full", > }); > $(".delete").on("click",function(e){ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt >index 79e4ecd7ff6..e8705705521 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt >@@ -60,7 +60,7 @@ > [% END %] > <script> > var clubs_dt_params = { >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > paginate: true, > }; > $("#table_clubnoenrollmemnts").kohaTable(clubs_dt_params); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt >index 62e8b423bc7..2c748ae84f5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt >@@ -112,7 +112,7 @@ > [% END %] > <script> > var patron_lists_dt_params = { >- columnDefs: [{ sortable: false, bSearchable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, bSearchable: false, targets: ["NoSort"] }], > sPaginationType: "full", > }; > $("#table_listnopatron").kohaTable(patron_lists_dt_params); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >index 60fc27ec5da..75e1a5215b8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >@@ -607,7 +607,7 @@ > var table = $("#table_additional_contents").kohaTable({ > order: [[4, "desc"]], > columnDefs: [ >- { sortable: false, searchable: false, targets: ["NoSort"] }, >+ { orderable: false, searchable: false, targets: ["NoSort"] }, > { type: "anti-the", targets: ["anti-the"] }, > ], > pagingType: "full_numbers", >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >index 3f4c2fd139f..2e7e1daad14 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >@@ -546,7 +546,7 @@ > if( $("#itemst").length > 0 ){ > var itemst = $("#itemst").kohaTable({ > order: [[1, "asc"]], >- columnDefs: [{ targets: [0, -1], sortable: false, searchable: false }], >+ columnDefs: [{ targets: [0, -1], orderable: false, searchable: false }], > columns: [null, { type: "anti-the" }, null, null, null], > }); > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt >index 9ec31d5c025..44d1abac7ad 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt >@@ -54,7 +54,7 @@ > $(document).ready(function () { > $("table").kohaTable({ > filter: false, >- columnDefs: [{ targets: [-1, -2], sortable: false }], >+ columnDefs: [{ targets: [-1, -2], orderable: false }], > }); > > $(".role").click(function () { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index 877d27aaf6e..b3a5bfad6c1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -335,7 +335,7 @@ > [% INCLUDE 'datatables.inc' %] > <script> > $("#illrequestlist").kohaTable({ >- columnDefs: [{ targets: [-1], sortable: false, searchable: false }], >+ columnDefs: [{ targets: [-1], orderable: false, searchable: false }], > order: [[3, "desc"]], > }); > $("#backend-dropdown-options").removeClass("nojs"); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >index 06a79b2eba3..8d77a81bbb7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >@@ -140,7 +140,7 @@ > details: { type: "column", target: -1 }, > }, > columnDefs: [ >- { targets: ["nosort"], sortable: false, searchable: false }, >+ { targets: ["nosort"], orderable: false, searchable: false }, > { type: "anti-the", targets: ["anti-the"] }, > { className: "dtr-control", orderable: false, targets: -1 }, > ], >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >index bed1862383c..068703ae32a 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >@@ -298,7 +298,7 @@ > order: [[1, "desc"]], > dom: '<"top"<"table_entries"><"table_controls"fB>>t', > columnDefs: [ >- { targets: [0], sortable: false, searchable: false }, >+ { targets: [0], orderable: false, searchable: false }, > { className: "dtr-control", orderable: false, targets: -1 }, > ], > language: { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index 23e6c98331a..ce995218f98 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -598,7 +598,7 @@ > $("#suggestt").kohaTable({ > "order": [[ 1, "asc" ]], > "columnDefs": [ >- [% IF ( loggedinusername ) %]{ "targets": [ 0 ], "sortable": false, "searchable": false }[% END %], >+ [% IF ( loggedinusername ) %]{ "targets": [ 0 ], "orderable": false, "searchable": false }[% END %], > { "className": 'dtr-control', "orderable": false, "targets": -1 }, > { responsivePriority: 1, targets: 1 } > ], >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >index 13a442a9352..6d3a52d8c44 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >@@ -298,7 +298,7 @@ > $("#mytagst").kohaTable({ > sorting: [[2, "asc"]], > columnDefs: [ >- { targets: [0], sortable: false, searchable: false }, >+ { targets: [0], orderable: false, searchable: false }, > { sType: "anti-the", aTargets: ["anti-the"] }, > { className: "dtr-control", orderable: false, targets: -1 }, > { responsivePriority: 1, targets: 2 }, >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >index 36c1cea0831..afb02184199 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >@@ -150,7 +150,7 @@ > $("#topissuest").kohaTable({ > sorting: [[3, "desc"]], > columnDefs: [ >- { sortable: false, searchable: false, targets: ["NoSort"] }, >+ { orderable: false, searchable: false, targets: ["NoSort"] }, > { type: "anti-the", targets: ["anti-the"] }, > { className: "dtr-control", orderable: false, targets: -1 }, > ], >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 8c2dfd52cf3..8a90f4de21b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -1210,7 +1210,7 @@ > "sorting" : [[ thIndex, 'asc' ]], > "dom": '<"top"<"table_entries"><"table_controls"fB>>t', > "columnDefs": [ >- { "targets": [ "nosort" ],"sortable": false,"searchable": false }, >+ { "targets": [ "nosort" ],"orderable": false,"searchable": false }, > { "type": "anti-the", "targets" : [ "anti-the" ] }, > { "visible": false, "targets" : [ "hidden" ] }, > { "className": 'dtr-control', "orderable": false, "targets": -1 } >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index 5e74f6d6d83..15f863e1228 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -461,7 +461,7 @@ > sorting: [[thIndex, "asc"]], > dom: '<"top"<"table_entries"><"table_controls"f>>t<"clear">', > columnDefs: [ >- { targets: ["nosort"], sortable: false, searchable: false }, >+ { targets: ["nosort"], orderable: false, searchable: false }, > { targets: ["noshow"], visible: false, searchable: false }, > { type: "anti-the", targets: ["anti-the"] }, > { visible: false, targets: ["hidden"] }, >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26553
:
175186
|
175187
|
175188
|
175189
|
175190
|
175191
|
175874
|
175875
|
175876
|
175877
|
175878
|
175879
|
176359
|
176360
|
176361
|
176362
|
176363
|
176364
|
176588
|
176589
|
176590
|
176591
|
177087
|
177088
|
177089
|
177090
|
177091
|
177092
|
177152
|
177153
|
177154
|
177155
|
177156
|
177157
|
177158
|
177234
|
177235
|
177236
|
177237
|
177238
|
177239
|
177240
|
177241
|
177242
|
177243
|
177246
|
177247
|
177264
|
177265
|
177271
|
177888
|
177889
|
177890
|
177891
|
177892
|
177893
|
177894
|
177895
|
177896
|
177897
|
177898
|
177899
|
177900
|
178508
|
178509
|
178510
|
178511
|
178512
|
178513
|
178514
|
178515
|
178516
|
178517
|
178518
|
178519
|
178520
|
178521
|
178522
|
178523
|
178524
|
178525
|
178526
|
178527
|
178528
| 178529 |
178530
|
178531
|
178532
|
178533