Bug 26553 - Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js)
Summary: Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js)
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: RM_priority
: 28058 38114 (view as bug list)
Depends on: 36640 38255 38594
Blocks: 30221 38472 38984 39081 39083
  Show dependency treegraph
 
Reported: 2020-09-28 10:34 UTC by Jonathan Druart
Modified: 2025-02-10 19:30 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 26553: Replace KohaTable with kohaTable (71.86 KB, patch)
2024-12-04 13:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff (20.29 KB, patch)
2024-12-04 13:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc (13.01 KB, patch)
2024-12-04 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable - OPAC (12.94 KB, patch)
2024-12-04 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC (4.26 KB, patch)
2024-12-04 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc - OPAC (6.28 KB, patch)
2024-12-04 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable (71.87 KB, patch)
2024-12-21 12:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff (20.29 KB, patch)
2024-12-21 12:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc (13.01 KB, patch)
2024-12-21 12:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable - OPAC (12.94 KB, patch)
2024-12-21 12:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC (4.26 KB, patch)
2024-12-21 12:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc - OPAC (6.28 KB, patch)
2024-12-21 12:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable (71.92 KB, patch)
2025-01-10 14:55 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff (20.34 KB, patch)
2025-01-10 14:55 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc (13.07 KB, patch)
2025-01-10 14:55 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable - OPAC (12.99 KB, patch)
2025-01-10 14:55 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC (4.31 KB, patch)
2025-01-10 14:55 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc - OPAC (6.33 KB, patch)
2025-01-10 14:55 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc (13.68 KB, patch)
2025-01-16 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable - OPAC (12.99 KB, patch)
2025-01-16 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC (4.31 KB, patch)
2025-01-16 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc - OPAC (6.33 KB, patch)
2025-01-16 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable (71.96 KB, patch)
2025-01-23 20:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff (20.34 KB, patch)
2025-01-23 20:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc (13.68 KB, patch)
2025-01-23 20:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable - OPAC (12.99 KB, patch)
2025-01-23 20:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC (4.31 KB, patch)
2025-01-23 20:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc - OPAC (6.33 KB, patch)
2025-01-23 20:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: (follow-up) Replace KohaTable with kohaTable - OPAC (947 bytes, patch)
2025-01-27 08:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable (72.03 KB, patch)
2025-01-27 08:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff (20.34 KB, patch)
2025-01-27 08:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc (13.68 KB, patch)
2025-01-27 08:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable - OPAC (13.07 KB, patch)
2025-01-27 08:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC (4.31 KB, patch)
2025-01-27 08:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc - OPAC (6.33 KB, patch)
2025-01-27 08:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable (71.95 KB, patch)
2025-01-28 09:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff (20.34 KB, patch)
2025-01-28 09:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc (13.68 KB, patch)
2025-01-28 09:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable - OPAC (13.07 KB, patch)
2025-01-28 09:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC (4.31 KB, patch)
2025-01-28 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Remove columns_settings.inc - OPAC (6.33 KB, patch)
2025-01-28 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Replace KohaTable with kohaTable - curbside pickups (1.40 KB, patch)
2025-01-28 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Bring default columnDefs back (2.62 KB, patch)
2025-01-28 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Fix incorrect occurrences of 'sortable' => 'orderable' (2.13 KB, patch)
2025-01-28 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Restore default 'paging: false' - OPAC (1.21 KB, patch)
2025-01-28 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Fix incorrect occurrences of 'sortable' => 'orderable' (14.19 KB, patch)
2025-01-28 10:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: Restore default 'paging: false' - OPAC (1.21 KB, patch)
2025-01-28 10:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26553: (follow-up) Fix patron attribute types page (1.01 KB, patch)
2025-01-28 11:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 26553: (follow-up) Fix pending patron discharges (863 bytes, patch)
2025-01-28 11:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 26553: Split Export and restore "clear filters" - OPAC (3.75 KB, patch)
2025-01-28 13:16 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2020-09-28 10:34:05 UTC
Code in prog/js/datatables.js and columns_settings.inc have both the (almost) same code for buttons.

Can we avoid that?
Comment 1 David Cook 2024-11-01 01:15:51 UTC
I just bumped into this myself recently and it drove me a little crazy...
Comment 2 Jonathan Druart 2024-11-28 15:46:42 UTC
Rescoping this bug.

I will make kohaTable works in the different cases, so we will have only one way to instanciate DataTable.
Comment 3 Jonathan Druart 2024-11-28 15:47:17 UTC
*** Bug 38114 has been marked as a duplicate of this bug. ***
Comment 4 Jonathan Druart 2024-12-04 13:56:55 UTC
Created attachment 175186 [details] [review]
Bug 26553: Replace KohaTable with kohaTable
Comment 5 Jonathan Druart 2024-12-04 13:56:58 UTC
Created attachment 175187 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff
Comment 6 Jonathan Druart 2024-12-04 13:57:01 UTC
Created attachment 175188 [details] [review]
Bug 26553: Remove columns_settings.inc
Comment 7 Jonathan Druart 2024-12-04 13:57:03 UTC
Created attachment 175189 [details] [review]
Bug 26553: Replace KohaTable with kohaTable - OPAC
Comment 8 Jonathan Druart 2024-12-04 13:57:06 UTC
Created attachment 175190 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC
Comment 9 Jonathan Druart 2024-12-04 13:57:09 UTC
Created attachment 175191 [details] [review]
Bug 26553: Remove columns_settings.inc - OPAC
Comment 10 Jonathan Druart 2024-12-04 13:58:36 UTC
Same as bug 38255, we remove KohaTable (columns_settings.inc) in favor of kohaTable.

At this point we have kohaTable available for both interfaces, for the different use cases (svc, REST API, no server-side processing).

We remove columns_settings.inc.

Test plan:
Test some table modified by this patchset.
Comment 11 Jonathan Druart 2024-12-04 14:07:27 UTC
QA:
`git grep KohaTable ':(exclude)*.vue' ':(exclude)misc/release_notes/' | wc -l`
must return 0
Comment 12 Lucas Gass (lukeg) 2024-12-20 15:01:05 UTC
I noticed two small problems when testing, both JS errors: 

acqui-home.tt: ReferenceError: oTable is not defined

itemsearch.tt: TypeError: order_by is undefined
Comment 13 Jonathan Druart 2024-12-21 12:23:49 UTC
Created attachment 175874 [details] [review]
Bug 26553: Replace KohaTable with kohaTable
Comment 14 Jonathan Druart 2024-12-21 12:23:52 UTC
Created attachment 175875 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff
Comment 15 Jonathan Druart 2024-12-21 12:23:55 UTC
Created attachment 175876 [details] [review]
Bug 26553: Remove columns_settings.inc
Comment 16 Jonathan Druart 2024-12-21 12:23:58 UTC
Created attachment 175877 [details] [review]
Bug 26553: Replace KohaTable with kohaTable - OPAC
Comment 17 Jonathan Druart 2024-12-21 12:24:02 UTC
Created attachment 175878 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC
Comment 18 Jonathan Druart 2024-12-21 12:24:05 UTC
Created attachment 175879 [details] [review]
Bug 26553: Remove columns_settings.inc - OPAC
Comment 19 Jonathan Druart 2024-12-21 12:25:05 UTC
(In reply to Lucas Gass (lukeg) from comment #12)

Thanks a lot!

> I noticed two small problems when testing, both JS errors: 
> 
> acqui-home.tt: ReferenceError: oTable is not defined

Fixed inline in the first patch.
-            $("#accounts").kohaTable({
+            var oTable $("#accounts").kohaTable({

> itemsearch.tt: TypeError: order_by is undefined

Fixed on "Bug 38255: Exception - Item search"
Comment 20 Lucas Gass (lukeg) 2025-01-10 14:55:17 UTC
Created attachment 176359 [details] [review]
Bug 26553: Replace KohaTable with kohaTable

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 21 Lucas Gass (lukeg) 2025-01-10 14:55:19 UTC
Created attachment 176360 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 22 Lucas Gass (lukeg) 2025-01-10 14:55:21 UTC
Created attachment 176361 [details] [review]
Bug 26553: Remove columns_settings.inc

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 23 Lucas Gass (lukeg) 2025-01-10 14:55:24 UTC
Created attachment 176362 [details] [review]
Bug 26553: Replace KohaTable with kohaTable - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 24 Lucas Gass (lukeg) 2025-01-10 14:55:26 UTC
Created attachment 176363 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 25 Lucas Gass (lukeg) 2025-01-10 14:55:28 UTC
Created attachment 176364 [details] [review]
Bug 26553: Remove columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 26 Katrin Fischer 2025-01-10 15:13:17 UTC
Awesome, thanks Lucas!
Comment 27 Jonathan Druart 2025-01-16 08:51:26 UTC
*** Bug 28058 has been marked as a duplicate of this bug. ***
Comment 28 Jonathan Druart 2025-01-16 08:52:37 UTC
Created attachment 176588 [details] [review]
Bug 26553: Remove columns_settings.inc

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 29 Jonathan Druart 2025-01-16 08:52:40 UTC
Created attachment 176589 [details] [review]
Bug 26553: Replace KohaTable with kohaTable - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 30 Jonathan Druart 2025-01-16 08:52:43 UTC
Created attachment 176590 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 31 Jonathan Druart 2025-01-16 08:52:47 UTC
Created attachment 176591 [details] [review]
Bug 26553: Remove columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 32 Owen Leonard 2025-01-23 18:51:18 UTC
This doesn't apply for me (on top of Bug 38255):

Applying: Bug 26553: Replace KohaTable with kohaTable
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 26553: Replace KohaTable with kohaTable
Comment 33 Jonathan Druart 2025-01-23 20:25:54 UTC
Created attachment 177087 [details] [review]
Bug 26553: Replace KohaTable with kohaTable

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 34 Jonathan Druart 2025-01-23 20:25:57 UTC
Created attachment 177088 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 35 Jonathan Druart 2025-01-23 20:26:01 UTC
Created attachment 177089 [details] [review]
Bug 26553: Remove columns_settings.inc

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 36 Jonathan Druart 2025-01-23 20:26:04 UTC
Created attachment 177090 [details] [review]
Bug 26553: Replace KohaTable with kohaTable - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 37 Jonathan Druart 2025-01-23 20:26:07 UTC
Created attachment 177091 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 38 Jonathan Druart 2025-01-23 20:26:10 UTC
Created attachment 177092 [details] [review]
Bug 26553: Remove columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 39 Jonathan Druart 2025-01-23 20:28:04 UTC
(In reply to Owen Leonard from comment #32)
> This doesn't apply for me (on top of Bug 38255):
> 
> Applying: Bug 26553: Replace KohaTable with kohaTable
> error: sha1 information is lacking or useless
> (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt).
> error: could not build fake ancestor
> Patch failed at 0001 Bug 26553: Replace KohaTable with kohaTable

Everything good for me here but I had a tiny conflict on bug 38255.

I pushed a branch to my gitlab repo in case it does not apply again, see bug_26553.
Comment 40 Jonathan Druart 2025-01-27 08:39:25 UTC
Created attachment 177152 [details] [review]
Bug 26553: (follow-up) Replace KohaTable with kohaTable - OPAC
Comment 41 Jonathan Druart 2025-01-27 08:45:27 UTC
Created attachment 177153 [details] [review]
Bug 26553: Replace KohaTable with kohaTable

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

JD Amended patch: replace wrong occurrences of "kohatable" with "kohaTable"
Comment 42 Jonathan Druart 2025-01-27 08:45:31 UTC
Created attachment 177154 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 43 Jonathan Druart 2025-01-27 08:45:35 UTC
Created attachment 177155 [details] [review]
Bug 26553: Remove columns_settings.inc

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 44 Jonathan Druart 2025-01-27 08:45:38 UTC
Created attachment 177156 [details] [review]
Bug 26553: Replace KohaTable with kohaTable - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

JD Amended patch: replace wrong occurrences of "kohatable" with "kohaTable"
Comment 45 Jonathan Druart 2025-01-27 08:45:41 UTC
Created attachment 177157 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 46 Jonathan Druart 2025-01-27 08:45:44 UTC
Created attachment 177158 [details] [review]
Bug 26553: Remove columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 47 Owen Leonard 2025-01-27 16:50:18 UTC
Looks like something got lost in the transition... There should be some defaults being set, e.g. 

        var default_column_defs = [
            { "aTargets": ["string-sort"], "sType": "string" },
            { "aTargets": ["anti-the"], "sType": "anti-the" },
            { "aTargets": ["NoSort"], "bSortable": false, "bSearchable": false }
        ];

I don't think this is working in the OPAC or staff interface. I should be able to remove the table options in a template (e.g. opac-user.tt) and still have the options work. I don't find this to be the case.
Comment 48 Owen Leonard 2025-01-27 16:54:08 UTC
It also looks like some defaults may be different? On opac-user.pl I notice that the holdings and holds tables don't show all their contents. It needs to be updated to add "paging: false" to show all results.
Comment 49 Jonathan Druart 2025-01-28 09:42:49 UTC
Created attachment 177234 [details] [review]
Bug 26553: Replace KohaTable with kohaTable

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

JD Amended patch: replace wrong occurrences of "kohatable" with "kohaTable"
Comment 50 Jonathan Druart 2025-01-28 09:42:52 UTC
Created attachment 177235 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 51 Jonathan Druart 2025-01-28 09:42:55 UTC
Created attachment 177236 [details] [review]
Bug 26553: Remove columns_settings.inc

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 52 Jonathan Druart 2025-01-28 09:42:58 UTC
Created attachment 177237 [details] [review]
Bug 26553: Replace KohaTable with kohaTable - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

JD Amended patch: replace wrong occurrences of "kohatable" with "kohaTable"
Comment 53 Jonathan Druart 2025-01-28 09:43:01 UTC
Created attachment 177238 [details] [review]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 54 Jonathan Druart 2025-01-28 09:43:05 UTC
Created attachment 177239 [details] [review]
Bug 26553: Remove columns_settings.inc - OPAC

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 55 Jonathan Druart 2025-01-28 09:43:08 UTC
Created attachment 177240 [details] [review]
Bug 26553: Replace KohaTable with kohaTable - curbside pickups

Adjust this new occurrence
Comment 56 Jonathan Druart 2025-01-28 09:43:11 UTC
Created attachment 177241 [details] [review]
Bug 26553: Bring default columnDefs back
Comment 57 Jonathan Druart 2025-01-28 09:43:14 UTC
Created attachment 177242 [details] [review]
Bug 26553: Fix incorrect occurrences of 'sortable' => 'orderable'
Comment 58 Jonathan Druart 2025-01-28 09:43:17 UTC
Created attachment 177243 [details] [review]
Bug 26553: Restore default 'paging: false' - OPAC
Comment 59 Jonathan Druart 2025-01-28 09:43:41 UTC
(In reply to Owen Leonard from comment #47)
> Looks like something got lost in the transition... There should be some
> defaults being set, e.g. 
> 
>         var default_column_defs = [
>             { "aTargets": ["string-sort"], "sType": "string" },
>             { "aTargets": ["anti-the"], "sType": "anti-the" },
>             { "aTargets": ["NoSort"], "bSortable": false, "bSearchable":
> false }
>         ];
> 
> I don't think this is working in the OPAC or staff interface. I should be
> able to remove the table options in a template (e.g. opac-user.tt) and still
> have the options work. I don't find this to be the case.

Good catch, should be fixed now (see "Bring default columnDefs back")

(In reply to Owen Leonard from comment #48)
> It also looks like some defaults may be different? On opac-user.pl I notice
> that the holdings and holds tables don't show all their contents. It needs
> to be updated to add "paging: false" to show all results.

See "Restore default 'paging: false' - OPAC". Did you notice another default that is wrong?
Comment 60 Jonathan Druart 2025-01-28 10:13:49 UTC
Created attachment 177246 [details] [review]
Bug 26553: Fix incorrect occurrences of 'sortable' => 'orderable'
Comment 61 Jonathan Druart 2025-01-28 10:13:52 UTC
Created attachment 177247 [details] [review]
Bug 26553: Restore default 'paging: false' - OPAC
Comment 62 Owen Leonard 2025-01-28 11:44:47 UTC
Created attachment 177264 [details] [review]
Bug 26553: (follow-up) Fix patron attribute types page
Comment 63 Owen Leonard 2025-01-28 11:44:49 UTC
Created attachment 177265 [details] [review]
Bug 26553: (follow-up) Fix pending patron discharges
Comment 64 Owen Leonard 2025-01-28 12:11:02 UTC
> See "Restore default 'paging: false' - OPAC". Did you notice another default
> that is wrong?

I notice that now the "Export" button is always shown, whereas previously it would only be shown if there were also column configuration buttons. I guess this makes sense because exporting is relevant whether or not the table can be configured. Looking at the other buttons in that set, I wonder if the "Copy shareable link" should also be globally enabled?
Comment 65 Jonathan Druart 2025-01-28 13:16:22 UTC
Created attachment 177271 [details] [review]
Bug 26553: Split Export and restore "clear filters" - OPAC

"Clear filters" is not in main but should be (I don't really understand
why it is not displayed).

The Export options were not grouped within an "Export" button in main,
this patch restores that.
Comment 66 Jonathan Druart 2025-01-28 13:18:27 UTC
(In reply to Owen Leonard from comment #64)
> > See "Restore default 'paging: false' - OPAC". Did you notice another default
> > that is wrong?
> 
> I notice that now the "Export" button is always shown, whereas previously it
> would only be shown if there were also column configuration buttons. I guess
> this makes sense because exporting is relevant whether or not the table can
> be configured. Looking at the other buttons in that set, I wonder if the
> "Copy shareable link" should also be globally enabled?

The last patch ungroup the export options and restore the "clear filters" button.

However I don't understand the "configuration" part, this is only for the staff interface.

Also the "copy shareable link" is not available for at the OPAC.