Bugzilla – Attachment 178539 Details for
Bug 39183
If using automatic return claim resolution on checkout, each checkout will overwrite the previous resolution (again)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39183: Only check unresolved claims
Bug-39183-Only-check-unresolved-claims.patch (text/plain), 1.88 KB, created by
Phil Ringnalda
on 2025-02-21 19:50:56 UTC
(
hide
)
Description:
Bug 39183: Only check unresolved claims
Filename:
MIME Type:
Creator:
Phil Ringnalda
Created:
2025-02-21 19:50:56 UTC
Size:
1.88 KB
patch
obsolete
>From 51b006c2f3efc8514a808c6bf8871e07d286176c Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Thu, 20 Feb 2025 16:59:30 -0500 >Subject: [PATCH] Bug 39183: Only check unresolved claims > >To test: >1. Set up sysprefs: > - Set any non-empty value for ClaimReturnedLostValue > - Set AutoClaimReturnStatusOnCheckout to "found in library" > - Set AutoClaimReturnStatusOnCheckin to "returned by patron" >2. Check out an item to a patron >3. On the patron's account page, click the "Claim Return" button next to > that checkout >4. Check the item in. Note the message that the claim was auto-resolved. >5. Return to the patron's account page and open the Claims Returned tab >--> Note that the claim is resolved and hidden >6. Click the "Show all 1 claims" link to view the hidden claim. Make a > note of the resolution code and timestamp. >7. Check the item out again >--> Note the message saying that the claim was resolved, even though it > was already resolved previously >8. View the return claim again >--> Note that the timestamp and resolution code have changed >9. Apply patch and restart_all >10. Repeat steps 2-8 with a new item >--> Note you do not get a claim resolved message on checkout this time >--> Note that the timestamp and resolution code remain the same before > and after the checkout > >Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> >--- > circ/circulation.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 75dc267041..e7732bfdc7 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -446,6 +446,7 @@ if ( @$barcodes && $op eq 'cud-checkout' ) { > my $claims = Koha::Checkouts::ReturnClaims->search( > { > itemnumber => $item->id, >+ resolution => undef, > } > ); > if ( $claims->count ) { >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39183
:
178538
|
178539
|
178873