Bug 39183 - If using automatic return claim resolution on checkout, each checkout will overwrite the previous resolution (again)
Summary: If using automatic return claim resolution on checkout, each checkout will ov...
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Emily Lamancusa (emlam)
QA Contact: Lisette Scheer
URL:
Keywords:
Depends on: 14787
Blocks:
  Show dependency treegraph
 
Reported: 2025-02-20 21:52 UTC by Emily Lamancusa (emlam)
Modified: 2025-03-22 11:40 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00, 24.11.03
Circulation function:


Attachments
Bug 39183: Only check unresolved claims (1.82 KB, patch)
2025-02-21 19:19 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 39183: Only check unresolved claims (1.88 KB, patch)
2025-02-21 19:50 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 39183: Only check unresolved claims (1.94 KB, patch)
2025-02-28 20:44 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2025-02-20 21:52:44 UTC
The fix from bug 38246 got deleted when a subsequent bug was rebased. :( Same problem, same fix.
Comment 1 Emily Lamancusa (emlam) 2025-02-21 19:19:55 UTC
Created attachment 178538 [details] [review]
Bug 39183: Only check unresolved claims

To test:
1. Set up sysprefs:
   - Set any non-empty value for ClaimReturnedLostValue
   - Set AutoClaimReturnStatusOnCheckout to "found in library"
   - Set AutoClaimReturnStatusOnCheckin to "returned by patron"
2. Check out an item to a patron
3. On the patron's account page, click the "Claim Return" button next to
   that checkout
4. Check the item in. Note the message that the claim was auto-resolved.
5. Return to the patron's account page and open the Claims Returned tab
--> Note that the claim is resolved and hidden
6. Click the "Show all 1 claims" link to view the hidden claim. Make a
   note of the resolution code and timestamp.
7. Check the item out again
--> Note the message saying that the claim was resolved, even though it
    was already resolved previously
8. View the return claim again
--> Note that the timestamp and resolution code have changed
9. Apply patch and restart_all
10. Repeat steps 2-8 with a new item
--> Note you do not get a claim resolved message on checkout this time
--> Note that the timestamp and resolution code remain the same before
    and after the checkout
Comment 2 Phil Ringnalda 2025-02-21 19:50:56 UTC
Created attachment 178539 [details] [review]
Bug 39183: Only check unresolved claims

To test:
1. Set up sysprefs:
   - Set any non-empty value for ClaimReturnedLostValue
   - Set AutoClaimReturnStatusOnCheckout to "found in library"
   - Set AutoClaimReturnStatusOnCheckin to "returned by patron"
2. Check out an item to a patron
3. On the patron's account page, click the "Claim Return" button next to
   that checkout
4. Check the item in. Note the message that the claim was auto-resolved.
5. Return to the patron's account page and open the Claims Returned tab
--> Note that the claim is resolved and hidden
6. Click the "Show all 1 claims" link to view the hidden claim. Make a
   note of the resolution code and timestamp.
7. Check the item out again
--> Note the message saying that the claim was resolved, even though it
    was already resolved previously
8. View the return claim again
--> Note that the timestamp and resolution code have changed
9. Apply patch and restart_all
10. Repeat steps 2-8 with a new item
--> Note you do not get a claim resolved message on checkout this time
--> Note that the timestamp and resolution code remain the same before
    and after the checkout

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Phil Ringnalda 2025-02-21 20:42:21 UTC
The rebase isn't going any further back, but it did land for 24.11 so this is needed there.
Comment 4 Lisette Scheer 2025-02-28 20:44:08 UTC
Created attachment 178873 [details] [review]
Bug 39183: Only check unresolved claims

Worked as expected


To test:
1. Set up sysprefs:
   - Set any non-empty value for ClaimReturnedLostValue
   - Set AutoClaimReturnStatusOnCheckout to "found in library"
   - Set AutoClaimReturnStatusOnCheckin to "returned by patron"
2. Check out an item to a patron
3. On the patron's account page, click the "Claim Return" button next to
   that checkout
4. Check the item in. Note the message that the claim was auto-resolved.
5. Return to the patron's account page and open the Claims Returned tab
--> Note that the claim is resolved and hidden
6. Click the "Show all 1 claims" link to view the hidden claim. Make a
   note of the resolution code and timestamp.
7. Check the item out again
--> Note the message saying that the claim was resolved, even though it
    was already resolved previously
8. View the return claim again
--> Note that the timestamp and resolution code have changed
9. Apply patch and restart_all
10. Repeat steps 2-8 with a new item
--> Note you do not get a claim resolved message on checkout this time
--> Note that the timestamp and resolution code remain the same before
    and after the checkout

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 5 Katrin Fischer 2025-03-07 14:04:12 UTC
Thanks Emily!
Comment 6 Katrin Fischer 2025-03-07 14:43:03 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Paul Derscheid 2025-03-19 23:18:24 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03