Bugzilla – Attachment 178609 Details for
Bug 39108
Clicking the 'Ignore' button on hold found modal for already-waiting hold does not dismiss the modal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal
Bug-39108-Prevent-Ignore-on-found-hold-from-trigge.patch (text/plain), 2.74 KB, created by
Andrew Fuerste-Henry
on 2025-02-24 16:40:31 UTC
(
hide
)
Description:
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-02-24 16:40:31 UTC
Size:
2.74 KB
patch
obsolete
>From 7925442c4fce4714d667a3f56864e75acf9fc63b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 21 Feb 2025 13:42:13 +0000 >Subject: [PATCH] Bug 39108: Prevent 'Ignore' on found hold from triggering a > new modal > >When ignoring a waiting hold, we don't need to take any further action, we >shoudlsimply close the modal > >This patch adds JS to prevent form submission > >To test: >1 - place a hold >2 - check in an item that can fill the hold >3 - in the hold found modal, click Ignore >4 - the modal dismisses and nothing changes on the hold (this is the desired behavior) >5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting >6 - check in the item again, confirm the modal says "Item is already waiting" >7 - click Ignore, confirm modal reloads >8 - click Ignore, confirm modal reloads >9 - click Ignore, confirm modal reloads >10 - Apply patch >11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting >12 - check in the item again, confirm the modal says "Item is already waiting" >13 - click Ignore, nothign happens! Orange you glad I didn't say banana? > >Signed-off-by: Amanda Campbell <acampbell@hmcpl.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 39c7500712..dc108a7f4e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -733,7 +733,7 @@ > > <input type="hidden" name="print_slip" value="0" /> > <button type="button" class="btn btn-default print" accesskey="P"> <i class="fa fa-print"></i> Print slip and confirm (P) </button> >- <button data-bs-dismiss="modal" type="submit" class="btn btn-default" accesskey="I"> <i class="fa fa-times"></i> Ignore (I) </button> >+ <button data-bs-dismiss="modal" type="submit" class="btn btn-default ignore" accesskey="I"> <i class="fa fa-times"></i> Ignore (I) </button> > > <fieldset class="action"> > [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %] >@@ -1616,6 +1616,9 @@ > if ( barcode ) barcode.remove(); > this.form.submit(); > }); >+ $(".ignore").on("click",function(e){ >+ e.preventDefault(); >+ }); > $('.cancel-hold').on("click",function(e){ > let cancel_form = document.getElementById('cancellation-reason'); > let cancel_reason = ''; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39108
:
178484
|
178609
|
178693