Bug 39108 - Clicking the 'Ignore' button on hold found modal for already-waiting hold does not dismiss the modal
Summary: Clicking the 'Ignore' button on hold found modal for already-waiting hold doe...
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-12 14:15 UTC by Andrew Fuerste-Henry
Modified: 2025-03-23 14:14 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.03
Circulation function:


Attachments
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal (2.69 KB, patch)
2025-02-21 13:45 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal (2.74 KB, patch)
2025-02-24 16:40 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal (2.81 KB, patch)
2025-02-25 16:54 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-02-12 14:15:03 UTC
To recreate:
1 - place a hold
2 - check in an item that can fill the hold
3 - in the hold found modal, click Ignore
4 - the modal dismisses and nothing changes on the hold (this is the desired behavior)
5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
6 - check in the item again, confirm the modal says "Item is already waiting"
7 - click Ignore, confirm modal reloads
8 - click Ignore, confirm modal reloads
9 - click Ignore, confirm modal reloads
Comment 1 Andrew Fuerste-Henry 2025-02-12 14:26:55 UTC
That said, if one clicks "Confirm" the modal goes away without sending a new notice of changing the state of the hold. That makes the Ignore button a little redundant.
Comment 2 Nick Clemens (kidclamp) 2025-02-21 13:45:18 UTC
Created attachment 178484 [details] [review]
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal

When ignoring a waiting hold, we don't need to take any further action, we
shoudlsimply close the modal

This patch adds JS to prevent form submission

To test:
1 - place a hold
2 - check in an item that can fill the hold
3 - in the hold found modal, click Ignore
4 - the modal dismisses and nothing changes on the hold (this is the desired behavior)
5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
6 - check in the item again, confirm the modal says "Item is already waiting"
7 - click Ignore, confirm modal reloads
8 - click Ignore, confirm modal reloads
9 - click Ignore, confirm modal reloads
10 - Apply patch
11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
12 - check in the item again, confirm the modal says "Item is already waiting"
13 - click Ignore, nothign happens! Orange you glad I didn't say banana?
Comment 3 Andrew Fuerste-Henry 2025-02-24 16:40:31 UTC
Created attachment 178609 [details] [review]
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal

When ignoring a waiting hold, we don't need to take any further action, we
shoudlsimply close the modal

This patch adds JS to prevent form submission

To test:
1 - place a hold
2 - check in an item that can fill the hold
3 - in the hold found modal, click Ignore
4 - the modal dismisses and nothing changes on the hold (this is the desired behavior)
5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
6 - check in the item again, confirm the modal says "Item is already waiting"
7 - click Ignore, confirm modal reloads
8 - click Ignore, confirm modal reloads
9 - click Ignore, confirm modal reloads
10 - Apply patch
11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
12 - check in the item again, confirm the modal says "Item is already waiting"
13 - click Ignore, nothign happens! Orange you glad I didn't say banana?

Signed-off-by: Amanda Campbell <acampbell@hmcpl.org>
Comment 4 Martin Renvoize (ashimema) 2025-02-25 16:54:30 UTC
Created attachment 178693 [details] [review]
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal

When ignoring a waiting hold, we don't need to take any further action, we
shoudlsimply close the modal

This patch adds JS to prevent form submission

To test:
1 - place a hold
2 - check in an item that can fill the hold
3 - in the hold found modal, click Ignore
4 - the modal dismisses and nothing changes on the hold (this is the desired behavior)
5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
6 - check in the item again, confirm the modal says "Item is already waiting"
7 - click Ignore, confirm modal reloads
8 - click Ignore, confirm modal reloads
9 - click Ignore, confirm modal reloads
10 - Apply patch
11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
12 - check in the item again, confirm the modal says "Item is already waiting"
13 - click Ignore, nothign happens! Orange you glad I didn't say banana?

Signed-off-by: Amanda Campbell <acampbell@hmcpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2025-02-26 12:19:51 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 6 Paul Derscheid 2025-03-23 14:09:30 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03