Bugzilla – Attachment 178782 Details for
Bug 39185
Holds priority drop-down contains extraneous 0's if there are found holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39185: Don't add select option if priority is 0
Bug-39185-Dont-add-select-option-if-priority-is-0.patch (text/plain), 1.98 KB, created by
Baptiste Wojtkowski (bwoj)
on 2025-02-27 14:06:29 UTC
(
hide
)
Description:
Bug 39185: Don't add select option if priority is 0
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2025-02-27 14:06:29 UTC
Size:
1.98 KB
patch
obsolete
>From 220baaadb20b55aa741e0710951d3409112ad419 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 21 Feb 2025 14:51:22 -0500 >Subject: [PATCH] Bug 39185: Don't add select option if priority is 0 > >To test: >1. Place several holds on a biblio record >2. Check in items from that record and confirm some (but not all) of the > holds >3. View the current holds on that record >4. Click on the drop-down to change the priority of a hold >--> Note that the drop-down contains one or more "0" options - one for > each in-transit or waiting hold >5. Apply patch and refresh the page >6. Click on the drop-down again >--> The drop-down now contains the correct options >7. Use the drop-down and the "Update holds" button to change hold > hold priorities a few times >--> Confirm that the priority is updated correctly > >Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> >Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index c2d717a9..2d65e83d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -61,7 +61,7 @@ > [% FOREACH priority IN all_priorities %] > [% IF priority == this_priority %] > <option value="[% priority | html %]" selected="selected">[% priority | html %]</option> >- [% ELSE %] >+ [% ELSIF priority > 0 %] > <option value="[% priority | html %]">[% priority | html %]</option> > [% END %] > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39185
:
178540
|
178543
| 178782