To reproduce: 1. Place several holds on a biblio record 2. Check in items from that record and confirm some (but not all) of those holds 3. View the current holds on that record 4. Click on the drop-down to change priority on one of the holds --> Note that the drop-down contains some "0" options - one for each in-transit or waiting hold 5. Try clicking on a "0" option --> The hold moves above the lowest found hold on the list 6. Click "Update holds" --> The hold moves to priority 1, and priorities of other pending holds are updated accordingly
Created attachment 178540 [details] [review] Bug 39185: Don't add select option if priority is 0 To test: 1. Place several holds on a biblio record 2. Check in items from that record and confirm some (but not all) of the holds 3. View the current holds on that record 4. Click on the drop-down to change the priority of a hold --> Note that the drop-down contains one or more "0" options - one for each in-transit or waiting hold 5. Apply patch and refresh the page 6. Click on the drop-down again --> The drop-down now contains the correct options 7. Use the drop-down and the "Update holds" button to change hold hold priorities a few times --> Confirm that the priority is updated correctly
Created attachment 178543 [details] [review] Bug 39185: Don't add select option if priority is 0 To test: 1. Place several holds on a biblio record 2. Check in items from that record and confirm some (but not all) of the holds 3. View the current holds on that record 4. Click on the drop-down to change the priority of a hold --> Note that the drop-down contains one or more "0" options - one for each in-transit or waiting hold 5. Apply patch and refresh the page 6. Click on the drop-down again --> The drop-down now contains the correct options 7. Use the drop-down and the "Update holds" button to change hold hold priorities a few times --> Confirm that the priority is updated correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 178782 [details] [review] Bug 39185: Don't add select option if priority is 0 To test: 1. Place several holds on a biblio record 2. Check in items from that record and confirm some (but not all) of the holds 3. View the current holds on that record 4. Click on the drop-down to change the priority of a hold --> Note that the drop-down contains one or more "0" options - one for each in-transit or waiting hold 5. Apply patch and refresh the page 6. Click on the drop-down again --> The drop-down now contains the correct options 7. Use the drop-down and the "Update holds" button to change hold hold priorities a few times --> Confirm that the priority is updated correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Pushed for 25.05! Well done everyone, thank you!