Bug 39185 - Holds priority drop-down contains extraneous 0's if there are found holds
Summary: Holds priority drop-down contains extraneous 0's if there are found holds
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Emily Lamancusa (emlam)
QA Contact: Baptiste Wojtkowski (bwoj)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-21 19:33 UTC by Emily Lamancusa (emlam)
Modified: 2025-02-27 16:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39185: Don't add select option if priority is 0 (1.86 KB, patch)
2025-02-21 20:03 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 39185: Don't add select option if priority is 0 (1.92 KB, patch)
2025-02-22 01:36 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 39185: Don't add select option if priority is 0 (1.98 KB, patch)
2025-02-27 14:06 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2025-02-21 19:33:42 UTC
To reproduce:
1. Place several holds on a biblio record
2. Check in items from that record and confirm some (but not all) of those holds
3. View the current holds on that record
4. Click on the drop-down to change priority on one of the holds
--> Note that the drop-down contains some "0" options - one for each in-transit or waiting hold
5. Try clicking on a "0" option
--> The hold moves above the lowest found hold on the list
6. Click "Update holds"
--> The hold moves to priority 1, and priorities of other pending holds are updated accordingly
Comment 1 Emily Lamancusa (emlam) 2025-02-21 20:03:11 UTC
Created attachment 178540 [details] [review]
Bug 39185: Don't add select option if priority is 0

To test:
1. Place several holds on a biblio record
2. Check in items from that record and confirm some (but not all) of the
    holds
3. View the current holds on that record
4. Click on the drop-down to change the priority of a hold
--> Note that the drop-down contains one or more "0" options - one for
    each in-transit or waiting hold
5. Apply patch and refresh the page
6. Click on the drop-down again
--> The drop-down now contains the correct options
7. Use the drop-down and the "Update holds" button to change hold
    hold priorities a few times
--> Confirm that the priority is updated correctly
Comment 2 Phil Ringnalda 2025-02-22 01:36:29 UTC
Created attachment 178543 [details] [review]
Bug 39185: Don't add select option if priority is 0

To test:
1. Place several holds on a biblio record
2. Check in items from that record and confirm some (but not all) of the
    holds
3. View the current holds on that record
4. Click on the drop-down to change the priority of a hold
--> Note that the drop-down contains one or more "0" options - one for
    each in-transit or waiting hold
5. Apply patch and refresh the page
6. Click on the drop-down again
--> The drop-down now contains the correct options
7. Use the drop-down and the "Update holds" button to change hold
    hold priorities a few times
--> Confirm that the priority is updated correctly

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Baptiste Wojtkowski (bwoj) 2025-02-27 14:06:29 UTC
Created attachment 178782 [details] [review]
Bug 39185: Don't add select option if priority is 0

To test:
1. Place several holds on a biblio record
2. Check in items from that record and confirm some (but not all) of the
    holds
3. View the current holds on that record
4. Click on the drop-down to change the priority of a hold
--> Note that the drop-down contains one or more "0" options - one for
    each in-transit or waiting hold
5. Apply patch and refresh the page
6. Click on the drop-down again
--> The drop-down now contains the correct options
7. Use the drop-down and the "Update holds" button to change hold
    hold priorities a few times
--> Confirm that the priority is updated correctly

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Comment 4 Katrin Fischer 2025-02-27 16:33:22 UTC
Pushed for 25.05!

Well done everyone, thank you!