Bugzilla – Attachment 179147 Details for
Bug 39299
cn_browser on 952$o fails to open from item editor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39299: Fix cataloguing plugins in serial item editor
Bug-39299-Fix-cataloguing-plugins-in-serial-item-e.patch (text/plain), 4.58 KB, created by
Julian Maurice
on 2025-03-11 09:21:53 UTC
(
hide
)
Description:
Bug 39299: Fix cataloguing plugins in serial item editor
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2025-03-11 09:21:53 UTC
Size:
4.58 KB
patch
obsolete
>From 0f5552d673f647dd506f13b1ff5052f806542246 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Tue, 11 Mar 2025 10:13:57 +0100 >Subject: [PATCH] Bug 39299: Fix cataloguing plugins in serial item editor > >Some CSS classes were missing, causing the corresponding event listener >to not be called. > >Adding the missing CSS classes caused the tag editor button to be moved >to the left of the input, because of 'float: left' for .tag_editor >It seems that float:left is useless now, at least in cataloguing where >we use 'display: flex' for those elements, so this patch removes it. > >Test plan: >1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g. > 952$o) >2. Go to the serial edition page and click on "Add item". This should > show an item form >3. Click on the tag editor button, the cn_browser.pl popup should appear >--- > C4/Items.pm | 2 +- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 1 - > .../intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 4 ++-- > 3 files changed, 3 insertions(+), 4 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index f1ac3616a0..763ed4cd97 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -1608,7 +1608,7 @@ sub PrepareItemrecordDisplay { > my $class = $plugin->noclick ? ' disabled' : ''; > my $title = $plugin->noclick ? 'No popup' : 'Tag editor'; > $subfield_data{marc_value} = >- qq[<input type="text" id="$subfield_data{id}" name="field_value" class="input_marceditor framework_plugin" size="50" maxlength="$maxlength" value="$defaultvalue" data-plugin="$plugin->{name}" /><a href="#" id="buttonDot_$subfield_data{id}" class="buttonDot $class" title="$title" data-plugin="$plugin->{name}">...</a>\n] >+ qq[<input type="text" id="$subfield_data{id}" name="field_value" class="input_marceditor framework_plugin" size="50" maxlength="$maxlength" value="$defaultvalue" data-plugin="$plugin->{name}" /><a href="#" id="buttonDot_$subfield_data{id}" class="buttonDot tag_editor framework_plugin $class" title="$title" data-plugin="$plugin->{name}">...</a>\n] > . $plugin->javascript; > } else { > warn $plugin->errstr; >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 47e85450ab..4a7ce5f8eb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -3435,7 +3435,6 @@ progress { > .tag_editor { > background: transparent url( "../img/edit-tag.png" ) top left no-repeat; > display: block; >- float: left; > height: 16px; > margin: 4px; > overflow: hidden; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index e8daf5fc3f..40d5f4cfaf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -330,7 +330,7 @@ > Item</a > > > </legend> >- <div class="cataloguing_additem_itemlist"> >+ <div class="cataloguing_additem_itemlist marc_editor"> > [% FOREACH item IN serialslis.items %] > <div id="item[% item.serialid | html %][% item.countitems | html %]" class="items"> > <ol >@@ -527,7 +527,7 @@ > Item</a > > > </legend> >- <div class="cataloguing_additem_itemlist"> >+ <div class="cataloguing_additem_itemlist marc_editor"> > <div id="item[% newserialloo.serialid | html %][% newserialloo.countitems | html %]" class="items"> > <ol > >[% FOREACH iteminformatio IN newserialloo.iteminformation %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39299
:
179146
|
179147
|
179152
|
179153
|
179154