Bug 39299 - cn_browser on 952$o fails to open from item editor
Summary: cn_browser on 952$o fails to open from item editor
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Julian Maurice
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: RM_priority
Depends on: 30975
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-11 07:31 UTC by Martin Renvoize (ashimema)
Modified: 2025-03-13 09:30 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39299: Fix cataloguing plugins in item editor (2.16 KB, patch)
2025-03-11 09:21 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 39299: Fix cataloguing plugins in serial item editor (4.58 KB, patch)
2025-03-11 09:21 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 39299: Fix cataloguing plugins in item editor (2.22 KB, patch)
2025-03-11 10:12 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 39299: Fix cataloguing plugins in serial item editor (4.65 KB, patch)
2025-03-11 10:12 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 39299: (follow-up) Consistent styling for authorities finder (1.56 KB, patch)
2025-03-11 10:12 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2025-03-11 07:31:49 UTC
Since bug 30975 if you set the cn_browser plugin for 952$o it fails to open in the item editor.
Comment 1 Julian Maurice 2025-03-11 09:21:50 UTC
Created attachment 179146 [details] [review]
Bug 39299: Fix cataloguing plugins in item editor

Some CSS classes were missing, causing the corresponding event listener
to not be called

Test plan:
1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g.
   952$o)
2. Go to the cataloguing module and edit an existing item
3. Click on the tag editor button, the cn_browser.pl popup should appear
Comment 2 Julian Maurice 2025-03-11 09:21:53 UTC
Created attachment 179147 [details] [review]
Bug 39299: Fix cataloguing plugins in serial item editor

Some CSS classes were missing, causing the corresponding event listener
to not be called.

Adding the missing CSS classes caused the tag editor button to be moved
to the left of the input, because of 'float: left' for .tag_editor
It seems that float:left is useless now, at least in cataloguing where
we use 'display: flex' for those elements, so this patch removes it.

Test plan:
1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g.
   952$o)
2. Go to the serial edition page and click on "Add item". This should
   show an item form
3. Click on the tag editor button, the cn_browser.pl popup should appear
Comment 3 Martin Renvoize (ashimema) 2025-03-11 10:12:10 UTC
Created attachment 179152 [details] [review]
Bug 39299: Fix cataloguing plugins in item editor

Some CSS classes were missing, causing the corresponding event listener
to not be called

Test plan:
1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g.
   952$o)
2. Go to the cataloguing module and edit an existing item
3. Click on the tag editor button, the cn_browser.pl popup should appear

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2025-03-11 10:12:12 UTC
Created attachment 179153 [details] [review]
Bug 39299: Fix cataloguing plugins in serial item editor

Some CSS classes were missing, causing the corresponding event listener
to not be called.

Adding the missing CSS classes caused the tag editor button to be moved
to the left of the input, because of 'float: left' for .tag_editor
It seems that float:left is useless now, at least in cataloguing where
we use 'display: flex' for those elements, so this patch removes it.

Test plan:
1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g.
   952$o)
2. Go to the serial edition page and click on "Add item". This should
   show an item form
3. Click on the tag editor button, the cn_browser.pl popup should appear

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2025-03-11 10:12:14 UTC
Created attachment 179154 [details] [review]
Bug 39299: (follow-up) Consistent styling for authorities finder

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2025-03-11 10:13:19 UTC
Clear correction, no regressions found and QA script happy.. going for a straight QA here.
Comment 7 Katrin Fischer 2025-03-13 09:22:29 UTC
Removed the additional space between words here: title="No  popup"
Comment 8 Katrin Fischer 2025-03-13 09:30:22 UTC
Pushed for 25.05!

Well done everyone, thank you!