Bugzilla – Attachment 179149 Details for
Bug 39246
Patron category charge limit inputs should be larger
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39246: Patron category charge limit inputs should be larger
Bug-39246-Patron-category-charge-limit-inputs-shou.patch (text/plain), 4.07 KB, created by
Magnus Enger
on 2025-03-11 09:32:00 UTC
(
hide
)
Description:
Bug 39246: Patron category charge limit inputs should be larger
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2025-03-11 09:32:00 UTC
Size:
4.07 KB
patch
obsolete
>From ccfd6e6d96bd4bc5a19c1eff7362cd3599a5fa85 Mon Sep 17 00:00:00 2001 >From: phette23 <phette23@gmail.com> >Date: Wed, 5 Mar 2025 15:51:51 -0800 >Subject: [PATCH] Bug 39246: Patron category charge limit inputs should be > larger > >To test: >- From /cgi-bin/koha/admin/categories.pl open a patron category to editing >- Note the short length of the three consecutive 'charge limit' inputs >- Apply patch >- Edit a patron category; there is no space to put in a limit like 100.00 > >Sponsored-By: California College of the Arts >Signed-off-by: Magnus Enger <magnus@libriotech.no> >--- > .../prog/en/modules/admin/categories.tt | 18 ++++-------------- > 1 file changed, 4 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >index 7455772448..0badc2cef4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >@@ -485,22 +485,13 @@ > </li> > <li> > <label for="noissuescharge">Checkout charge limit: </label> >- <input type="text" pattern="^\d+(\.\d{2})?$" name="noissuescharge" id="noissuescharge" value="[% category.noissuescharge | $Price on_editing => 1 %]" class="decimal" size="3" maxlength="4" /> >+ <input type="text" pattern="^\d+(\.\d{2})?$" name="noissuescharge" id="noissuescharge" value="[% category.noissuescharge | $Price on_editing => 1 %]" size="5" maxlength="8" /> > [%- SET pref_noissuescharge_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=noissuescharge&ok=Search">noissuescharge</a>' -%] > <div class="hint">If set, this will override the global value set in the [%- pref_noissuescharge_link | $raw | $KohaSpan -%] preference.</div> > </li> > <li> > <label for="noissueschargeguarantees">Guarantees checkout charge limit: </label> >- <input >- type="text" >- pattern="^\d+(\.\d{2})?$" >- name="noissueschargeguarantees" >- id="noissueschargeguarantees" >- value="[% category.noissueschargeguarantees | $Price on_editing => 1 %]" >- class="decimal" >- size="3" >- maxlength="4" >- /> >+ <input type="text" pattern="^\d+(\.\d{2})?$" name="noissueschargeguarantees" id="noissueschargeguarantees" value="[% category.noissueschargeguarantees | $Price on_editing => 1 %]" size="5" maxlength="8" /> > [%- SET pref_NoIssuesChargeGuarantees_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=NoIssuesChargeGuarantees&ok=Search">NoIssuesChargeGuarantees</a>' -%] > <div class="hint">If set, this will override the global value set in the [%- pref_NoIssuesChargeGuarantees_link | $raw | $KohaSpan -%] preference.</div> > </li> >@@ -512,9 +503,8 @@ > name="noissueschargeguarantorswithguarantees" > id="noissueschargeguarantorswithguarantees" > value="[% category.noissueschargeguarantorswithguarantees | $Price on_editing => 1 %]" >- class="decimal" >- size="3" >- maxlength="4" >+ size="5" >+ maxlength="8" > /> > [%- SET pref_NoIssuesChargeGuarantorsWithGuarantees_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=NoIssuesChargeGuarantees&ok=Search">NoIssuesChargeGuarantees</a>' -%] > <div class="hint">If set, this will override the global value set in the [%- pref_NoIssuesChargeGuarantorsWithGuarantees_link | $raw | $KohaSpan -%] preference.</div> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39246
:
179005
|
179149
|
179350