Bug 39246 - Patron category charge limit inputs should be larger
Summary: Patron category charge limit inputs should be larger
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 24.11
Hardware: All All
: P5 - low minor
Assignee: Eric Phetteplace
QA Contact: Lisette Scheer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-05 00:13 UTC by Eric Phetteplace
Modified: 2025-03-17 07:28 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39246: Patron category charge limit inputs should be larger (4.02 KB, patch)
2025-03-05 23:53 UTC, Eric Phetteplace
Details | Diff | Splinter Review
Bug 39246: Patron category charge limit inputs should be larger (4.07 KB, patch)
2025-03-11 09:32 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 39246: Patron category charge limit inputs should be larger (4.13 KB, patch)
2025-03-14 19:48 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Phetteplace 2025-03-05 00:13:26 UTC
The various charge limit settings for a patron category (noissuescharge, noissueschargeguarantees, and noissueschargeguarantorswithguarantees) are too short. The size of all these inputs is only 3 characters and their max length is 4. This is too small for many of the valid values that might be chosen. For instance, if you want to set a charge limit over 100 currency units, you will not be able to use decimals (because "100." takes up the maximum of four characters). This won't work well for currencies where an individual unit is low value. It's awkward for us if I want to write "50.00" in. These are INT 10 fields in the database so I think it shouldn't cause any problems to lengthen the inputs.
Comment 1 Eric Phetteplace 2025-03-05 23:30:40 UTC Comment hidden (obsolete)
Comment 2 Eric Phetteplace 2025-03-05 23:49:45 UTC
Never mind, the decimal issue runs deeper, because the $Price on_editing filter makes these integers look like decimals in HTML. The decimal class itself appears to do nothing. I think the fields need to be decimals in the database but that is a more sophisticated change than I am capable of making at the moment so I'm narrowing the scope of the bug again.
Comment 3 Eric Phetteplace 2025-03-05 23:53:02 UTC Comment hidden (obsolete)
Comment 4 Magnus Enger 2025-03-11 09:32:00 UTC
Created attachment 179149 [details] [review]
Bug 39246: Patron category charge limit inputs should be larger

To test:
- From /cgi-bin/koha/admin/categories.pl open a patron category to editing
- Note the short length of the three consecutive 'charge limit' inputs
- Apply patch
- Edit a patron category; there is no space to put in a limit like 100.00

Sponsored-By: California College of the Arts
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Comment 5 Lisette Scheer 2025-03-14 19:48:00 UTC
Created attachment 179350 [details] [review]
Bug 39246: Patron category charge limit inputs should be larger

To test:
- From /cgi-bin/koha/admin/categories.pl open a patron category to editing
- Note the short length of the three consecutive 'charge limit' inputs
- Apply patch
- Edit a patron category; there is no space to put in a limit like 100.00

Sponsored-By: California College of the Arts
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 6 Katrin Fischer 2025-03-17 07:28:33 UTC
Pushed for 25.05!

Well done everyone, thank you!