The various charge limit settings for a patron category (noissuescharge, noissueschargeguarantees, and noissueschargeguarantorswithguarantees) are too short. The size of all these inputs is only 3 characters and their max length is 4. This is too small for many of the valid values that might be chosen. For instance, if you want to set a charge limit over 100 currency units, you will not be able to use decimals (because "100." takes up the maximum of four characters). This won't work well for currencies where an individual unit is low value. It's awkward for us if I want to write "50.00" in. These are INT 10 fields in the database so I think it shouldn't cause any problems to lengthen the inputs.
The class for these inputs is "decimal" but they are an integer field in the database. If you input "50.5", which the decimal class makes it looks like is a valid choice, it is rounded up to "51" in the database which seems like very unexpected behavior. I am going to broaden the scope of this bug rather than create a new one.
Never mind, the decimal issue runs deeper, because the $Price on_editing filter makes these integers look like decimals in HTML. The decimal class itself appears to do nothing. I think the fields need to be decimals in the database but that is a more sophisticated change than I am capable of making at the moment so I'm narrowing the scope of the bug again.
Created attachment 179005 [details] [review] Bug 39246: Patron category charge limit inputs should be larger To test: - From /cgi-bin/koha/admin/categories.pl open a patron category to editing - Note the short length of the three consecutive 'charge limit' inputs - Apply patch - Edit a patron category; there is no space to put in a limit like 100.00 Sponsored-By: California College of the Arts
Created attachment 179149 [details] [review] Bug 39246: Patron category charge limit inputs should be larger To test: - From /cgi-bin/koha/admin/categories.pl open a patron category to editing - Note the short length of the three consecutive 'charge limit' inputs - Apply patch - Edit a patron category; there is no space to put in a limit like 100.00 Sponsored-By: California College of the Arts Signed-off-by: Magnus Enger <magnus@libriotech.no>
Created attachment 179350 [details] [review] Bug 39246: Patron category charge limit inputs should be larger To test: - From /cgi-bin/koha/admin/categories.pl open a patron category to editing - Note the short length of the three consecutive 'charge limit' inputs - Apply patch - Edit a patron category; there is no space to put in a limit like 100.00 Sponsored-By: California College of the Arts Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Pushed for 25.05! Well done everyone, thank you!