Bugzilla – Attachment 179234 Details for
Bug 33544
Squash some ILL fields to alleviate request table overflow
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33544: Replace title details with one column
Bug-33544-Replace-title-details-with-one-column.patch (text/plain), 8.62 KB, created by
Lisette Scheer
on 2025-03-12 20:05:31 UTC
(
hide
)
Description:
Bug 33544: Replace title details with one column
Filename:
MIME Type:
Creator:
Lisette Scheer
Created:
2025-03-12 20:05:31 UTC
Size:
8.62 KB
patch
obsolete
>From 05ccf02d1bc7315f921de97892198ab1add435e1 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 5 May 2023 13:44:31 +0100 >Subject: [PATCH] Bug 33544: Replace title details with one column > >Combine the request title details fields into onea column for display. > >Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> >--- > .../prog/en/includes/ill-list-table.inc | 8 +- > .../intranet-tmpl/prog/js/ill-list-table.js | 119 ++++++++++-------- > 2 files changed, 66 insertions(+), 61 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >index bf314c26e10..abf1d1f15fa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >@@ -9,13 +9,7 @@ > <tr id="ill_requests_header"> > <th scope="col">Request ID</th> > <th scope="col">Batch</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="author" data-related-search-on="value">Author</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="title" data-related-search-on="value">Title</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="article_title" data-related-search-on="value">Article title</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="issue" data-related-search-on="value">Issue</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="volume" data-related-search-on="value">Volume</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="year" data-related-search-on="value">Year</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="pages" data-related-search-on="value">Pages</th> >+ <th scope="col">Request details</th> > <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="type" data-related-search-on="value">Request type</th> > <th scope="col">Order ID</th> > <th scope="col">Patron</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >index 0fc313a2213..84bac7ea965 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >@@ -270,62 +270,73 @@ $(document).ready(function () { > }, > }, > { >- data: "", // author >+ data: "", // Request details > orderable: false, > render: function (data, type, row, meta) { >- const author = display_extended_attribute( >- row, >- "author" >- ); >- if (author) return author; >- const articleAuthor = display_extended_attribute( >- row, >- "article_author" >- ); >- if (articleAuthor) return articleAuthor; >- return ""; >- }, >- }, >- { >- data: "", // title >- orderable: false, >- render: function (data, type, row, meta) { >- return display_extended_attribute(row, "title"); >- }, >- }, >- { >- data: "", // article_title >- orderable: false, >- render: function (data, type, row, meta) { >- return display_extended_attribute(row, "article_title"); >- }, >- }, >- { >- data: "", // issue >- orderable: false, >- render: function (data, type, row, meta) { >- return display_extended_attribute(row, "issue"); >- }, >- }, >- { >- data: "", // volume >- orderable: false, >- render: function (data, type, row, meta) { >- return display_extended_attribute(row, "volume"); >- }, >- }, >- { >- data: "", // year >- orderable: false, >- render: function (data, type, row, meta) { >- return display_extended_attribute(row, "year"); >- }, >- }, >- { >- data: "", // pages >- orderable: false, >- render: function (data, type, row, meta) { >- return display_extended_attribute(row, "pages"); >+ let display = ""; >+ if ( >+ display_extended_attribute(row, "article_title") !== >+ "" >+ ) { >+ display += >+ '<span style="display:block"> Article: ' + >+ display_extended_attribute( >+ row, >+ "article_title" >+ ) + >+ "</span>"; >+ } >+ if (display_extended_attribute(row, "title") !== "") { >+ display += >+ '<span style="display:block"> Title: ' + >+ display_extended_attribute(row, "title") + >+ "</span>"; >+ } >+ if ( >+ display_extended_attribute( >+ row, >+ "article_author" >+ ) !== "" >+ ) { >+ display += >+ '<span style="display:block"> Article author: ' + >+ display_extended_attribue( >+ row, >+ "article_author" >+ ) + >+ "</span>"; >+ } >+ if (display_extended_attribute(row, "author") !== "") { >+ display += >+ '<span style="display:block"> Author: ' + >+ display_extended_attribute(row, "author") + >+ "</span>"; >+ } >+ if (display_extended_attribute(row, "issue") !== "") { >+ display += >+ '<span style="display:block"> Issue: ' + >+ display_extended_attribute(row, "issue") + >+ "</span>"; >+ } >+ if (display_extended_attribute(row, "volume") !== "") { >+ display += >+ '<span style="display:block"> Volume: ' + >+ display_extended_attribute(row, "volume") + >+ "</span>"; >+ } >+ if (display_extended_attribute(row, "year") !== "") { >+ display += >+ '<span style="display:block"> Year: ' + >+ display_extended_attribute(row, "year") + >+ "</span>"; >+ } >+ if (display_extended_attribute(row, "pages") !== "") { >+ display += >+ '<span style="display:block"> Pages: ' + >+ display_extended_attribute(row, "pages") + >+ "</span>"; >+ } >+ return display; > }, > }, > { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33544
:
152860
|
152861
|
152862
|
152863
|
159528
|
159529
|
159530
|
162945
|
162946
|
162947
|
179227
|
179228
|
179229
|
179232
|
179233
| 179234