Bugzilla – Attachment 179370 Details for
Bug 39319
xt/author/podcorrectness.t only test POD for perl files within C4 and Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39319: Make podcorrectness.t test controller and test perl files
Bug-39319-Make-podcorrectnesst-test-controller-and.patch (text/plain), 1.95 KB, created by
David Nind
on 2025-03-16 19:26:48 UTC
(
hide
)
Description:
Bug 39319: Make podcorrectness.t test controller and test perl files
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-03-16 19:26:48 UTC
Size:
1.95 KB
patch
obsolete
>From e455d75ddf59c62a4a36f9ed43165561f88b765c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 13 Mar 2025 09:47:27 +0100 >Subject: [PATCH] Bug 39319: Make podcorrectness.t test controller and test > perl files > >It only tested files within C4 and Koha directories. > >Now we test all the perl files that are in the git index. > >Test plan: >0. Do not apply those patches >1. prove xt/author/podcorrectness.t >Notice "Tests=1208" meaning that 1208 files are tested >2. Apply this patch (not the second one) >It fails, and more files are being tested (3254) >xt/author/podcorrectness.t .. 1994/3254 >xt/author/podcorrectness.t .. 2726/3254 # Looks like you failed 1 test of 3254. >3. Apply the second patch >=> It passes! > >Signed-off-by: David Nind <david@davidnind.com> >--- > xt/author/podcorrectness.t | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/xt/author/podcorrectness.t b/xt/author/podcorrectness.t >index f1baf333fe..1f86f15610 100755 >--- a/xt/author/podcorrectness.t >+++ b/xt/author/podcorrectness.t >@@ -1,5 +1,4 @@ > #!/usr/bin/env perl >-use Modern::Perl; > > =head2 podcorrectness.t > >@@ -8,16 +7,17 @@ correctness. It typically finds things like pod tags withouth blank > lines immediately before or after them, unknown directives, or =over, > =item, and =back in the wrong order. > >-You must have Test::Pod installed. >- >-One good way to run this is with C<prove -v >-xt/author/podcorrectness.t> >+One good way to run this is with C<prove -v xt/author/podcorrectness.t> > > =cut > >+use Modern::Perl; > use Test::More; >-eval "use Test::Pod 1.00"; >-plan skip_all => "Test::Pod 1.00 required for testing POD" if $@; >-my @poddirs = qw( C4 Koha ); >-all_pod_files_ok( all_pod_files(@poddirs) ); >+use Test::Pod; >+ >+my @files; >+push @files, qx{git ls-files '*.pl' '*.PL' '*.pm' '*.t'}; >+push @files, qx{git ls-files svc opac/svc}; # Files without extension >+chomp for @files; > >+all_pod_files_ok(@files); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39319
:
179237
|
179238
|
179274
|
179275
|
179370
|
179371
|
179372
|
179373
|
179450
|
179664
|
179665
|
179666
|
179667
|
179668