It should also test controllers and tests.
Created attachment 179237 [details] [review] Bug 39319: Make podcorrectness.t test controller and test perl files It only tested files within C4 and Koha directories. Now we test all the perl files that are in the git index. Test plan: 0. Do not apply those patches 1. prove xt/author/podcorrectness.t Notice "Tests=1208" meaning that 1208 files are tested 2. Apply this patch (not the second one) It fails, and more files are being tested (3254) xt/author/podcorrectness.t .. 1994/3254 xt/author/podcorrectness.t .. 2726/3254 # Looks like you failed 1 test of 3254. 3. Apply the second patch => It passes!
Created attachment 179238 [details] [review] Bug 39319: Fix POD for misc/migration_tools/koha-svc.pl
Created attachment 179274 [details] [review] Bug 39319: Add test using Pod::Checker podchecker is used by the QA script and catch more than Test::Pod
Created attachment 179275 [details] [review] Bug 39319: Fixes for Pod::Checker
Created attachment 179370 [details] [review] Bug 39319: Make podcorrectness.t test controller and test perl files It only tested files within C4 and Koha directories. Now we test all the perl files that are in the git index. Test plan: 0. Do not apply those patches 1. prove xt/author/podcorrectness.t Notice "Tests=1208" meaning that 1208 files are tested 2. Apply this patch (not the second one) It fails, and more files are being tested (3254) xt/author/podcorrectness.t .. 1994/3254 xt/author/podcorrectness.t .. 2726/3254 # Looks like you failed 1 test of 3254. 3. Apply the second patch => It passes! Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179371 [details] [review] Bug 39319: Fix POD for misc/migration_tools/koha-svc.pl Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179372 [details] [review] Bug 39319: Add test using Pod::Checker podchecker is used by the QA script and catch more than Test::Pod Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179373 [details] [review] Bug 39319: Fixes for Pod::Checker Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179450 [details] [review] Bug 39319: Improve pod_checker.t It was not failing when warnings were found
Created attachment 179664 [details] [review] Bug 39319: Make podcorrectness.t test controller and test perl files It only tested files within C4 and Koha directories. Now we test all the perl files that are in the git index. Test plan: 0. Do not apply those patches 1. prove xt/author/podcorrectness.t Notice "Tests=1208" meaning that 1208 files are tested 2. Apply this patch (not the second one) It fails, and more files are being tested (3254) xt/author/podcorrectness.t .. 1994/3254 xt/author/podcorrectness.t .. 2726/3254 # Looks like you failed 1 test of 3254. 3. Apply the second patch => It passes! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 179665 [details] [review] Bug 39319: Fix POD for misc/migration_tools/koha-svc.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 179666 [details] [review] Bug 39319: Add test using Pod::Checker podchecker is used by the QA script and catch more than Test::Pod Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 179667 [details] [review] Bug 39319: Fixes for Pod::Checker Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 179668 [details] [review] Bug 39319: Improve pod_checker.t It was not failing when warnings were found Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>