Bugzilla – Attachment 179383 Details for
Bug 39354
Remove unintended Bootstrap 5 change to scroll-behavior
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior
Bug-39354-Remove-unintended-Bootstrap-5-change-to-.patch (text/plain), 3.12 KB, created by
Owen Leonard
on 2025-03-17 10:44:54 UTC
(
hide
)
Description:
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-03-17 10:44:54 UTC
Size:
3.12 KB
patch
obsolete
>From 448ee18a8363781b30743143586ce436fbc40eec Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 17 Mar 2025 10:26:21 +0000 >Subject: [PATCH] Bug 39354: Remove unintended Bootstrap 5 change to > scroll-behavior > >This patch updates the "variables" SCSS file in the OPAC and staff >interface in order to disable the "smooth scroll" behavior introduced in >Bootstrap 5. This was an unexpected and unintentional change. > >The patch also corrects another unexpected side-effect of the BS5 >upgrade: A change to the "cursor" property of elements with a >".placeholder" class. This class is used by the multiple-select jQuery >plugin found in some system preference controls. > >To test, apply the patch and rebuild the staff and OPAC CSS. > >- Clear your browser cache if necessary. >- In the staff interface, go to Administration -> System preferences -> > Circulation, and click "Patron restrictions" in the left-hand sidebar. > The page should jump immediately to that section without any scrolling > effect. >- Go to the "Article requests" section of that page. Hover your cursor > over a dropdown which doesn't have any option selected. Your cursor > should not change to a "waiting" cursor. >--- > koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss | 2 +- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 5 +++++ > koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss | 2 +- > 3 files changed, 7 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss >index f19c917b5cb..4f460c9cb72 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_variables.scss >@@ -376,7 +376,7 @@ $enable-shadows: false; > $enable-gradients: false; > $enable-transitions: true; > $enable-reduced-motion: true; >-$enable-smooth-scroll: true; >+$enable-smooth-scroll: false; > $enable-grid-classes: true; > $enable-container-classes: true; > $enable-cssgrid: false; >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 47e85450abc..8695e502415 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -117,6 +117,11 @@ $enable-dark-mode: false; > white-space: nowrap; > } > >+.placeholder { >+ /* Override Bootstrap style which conflicts with multiple-select */ >+ cursor: default; >+} >+ > .dropup .dropdown-menu[data-bs-popper] { > margin-bottom: 0; > } >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss >index 5ed6dc7ccd8..a13d77991cb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/_variables.scss >@@ -382,7 +382,7 @@ $enable-shadows: false; > $enable-gradients: false; > $enable-transitions: true; > $enable-reduced-motion: true; >-$enable-smooth-scroll: true; >+$enable-smooth-scroll: false; > $enable-grid-classes: true; > $enable-container-classes: true; > $enable-cssgrid: false; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39354
:
179383
|
179415
|
179421
|
179447