Bug 39354 - Remove unintended Bootstrap 5 change to scroll-behavior
Summary: Remove unintended Bootstrap 5 change to scroll-behavior
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: additional_work_needed
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-17 10:23 UTC by Owen Leonard
Modified: 2025-03-19 10:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes two unexpected and unintentional Bootstrap 5 changes: - It updates the "smooth scroll" behavior introduced in Bootstrap 5 for in-page links. Example: when clicking on a section link for a system administration, the page should jump immediately to that section instead of scrolling. - It updates some multiple-select dropdown lists used by some system preference controls, where a default option is not selected. When you hovered over the dropdown list, the cursor changed to a "waiting" cursor (rotating circle), this behavour is now removed. Example: the ArticleRequestsMandatoryFields system preference.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior (3.12 KB, patch)
2025-03-17 10:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior (3.17 KB, patch)
2025-03-17 16:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior (3.25 KB, patch)
2025-03-18 08:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39354: (follow-up) Override additional BS5 CSS for multiple-select (941 bytes, patch)
2025-03-18 11:41 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-03-17 10:23:43 UTC
Bootstrap 5 introduced a change to the global CSS property "scroll-behavior." This adds a "smooth scrolling" behavior to in-page links, e.g. Administration -> System preferences -> Circulation -> Patron restrictions (from the sidebar menu).

This is a fairly "opinionated" change on Bootstrap's part and since it wasn't an intentional change I think we should switch it back.
Comment 1 Owen Leonard 2025-03-17 10:44:54 UTC
Created attachment 179383 [details] [review]
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior

This patch updates the "variables" SCSS file in the OPAC and staff
interface in order to disable the "smooth scroll" behavior introduced in
Bootstrap 5. This was an unexpected and unintentional change.

The patch also corrects another unexpected side-effect of the BS5
upgrade: A change to the "cursor" property of elements with a
".placeholder" class. This class is used by the multiple-select jQuery
plugin found in some system preference controls.

To test, apply the patch and rebuild the staff and OPAC CSS.

- Clear your browser cache if necessary.
- In the staff interface, go to Administration -> System preferences ->
  Circulation, and click "Patron restrictions" in the left-hand sidebar.
  The page should jump immediately to that section without any scrolling
  effect.
- Go to the "Article requests" section of that page. Hover your cursor
  over a dropdown which doesn't have any option selected. Your cursor
  should not change to a "waiting" cursor.
Comment 2 David Nind 2025-03-17 16:22:59 UTC
Created attachment 179415 [details] [review]
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior

This patch updates the "variables" SCSS file in the OPAC and staff
interface in order to disable the "smooth scroll" behavior introduced in
Bootstrap 5. This was an unexpected and unintentional change.

The patch also corrects another unexpected side-effect of the BS5
upgrade: A change to the "cursor" property of elements with a
".placeholder" class. This class is used by the multiple-select jQuery
plugin found in some system preference controls.

To test, apply the patch and rebuild the staff and OPAC CSS.

- Clear your browser cache if necessary.
- In the staff interface, go to Administration -> System preferences ->
  Circulation, and click "Patron restrictions" in the left-hand sidebar.
  The page should jump immediately to that section without any scrolling
  effect.
- Go to the "Article requests" section of that page. Hover your cursor
  over a dropdown which doesn't have any option selected. Your cursor
  should not change to a "waiting" cursor.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2025-03-18 08:39:34 UTC
Created attachment 179421 [details] [review]
Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior

This patch updates the "variables" SCSS file in the OPAC and staff
interface in order to disable the "smooth scroll" behavior introduced in
Bootstrap 5. This was an unexpected and unintentional change.

The patch also corrects another unexpected side-effect of the BS5
upgrade: A change to the "cursor" property of elements with a
".placeholder" class. This class is used by the multiple-select jQuery
plugin found in some system preference controls.

To test, apply the patch and rebuild the staff and OPAC CSS.

- Clear your browser cache if necessary.
- In the staff interface, go to Administration -> System preferences ->
  Circulation, and click "Patron restrictions" in the left-hand sidebar.
  The page should jump immediately to that section without any scrolling
  effect.
- Go to the "Article requests" section of that page. Hover your cursor
  over a dropdown which doesn't have any option selected. Your cursor
  should not change to a "waiting" cursor.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2025-03-18 08:39:44 UTC
Better but it still looks like the select2 are disabled IMO.
Comment 5 Owen Leonard 2025-03-18 11:41:20 UTC
Created attachment 179447 [details] [review]
Bug 39354: (follow-up) Override additional BS5 CSS for multiple-select
Comment 6 Katrin Fischer 2025-03-19 10:56:41 UTC
Pushed for 25.05!

Well done everyone, thank you!