Bugzilla – Attachment 179473 Details for
Bug 39356
Accessibility 1.3.1: There are pages where heading levels are skipped
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39356 - Change heading ranks when ranks are skipped
Bug-39356---Change-heading-ranks-when-ranks-are-sk.patch (text/plain), 14.70 KB, created by
Nina Martinez
on 2025-03-19 13:52:37 UTC
(
hide
)
Description:
Bug 39356 - Change heading ranks when ranks are skipped
Filename:
MIME Type:
Creator:
Nina Martinez
Created:
2025-03-19 13:52:37 UTC
Size:
14.70 KB
patch
obsolete
>From 8a6c7a7e8ab38f7f261de8854cbe9e47d59b5371 Mon Sep 17 00:00:00 2001 >From: nina martinez <nina.martinez@biblibre.com> >Date: Wed, 19 Mar 2025 14:10:29 +0100 >Subject: [PATCH] Bug 39356 - Change heading ranks when ranks are skipped > >Test plan: > >1- Check all headings on the pages (you can use tools like HeadingsMap) >2- Verify that no heading ranks are skipped >3- If it's the case, the test succeeds >--- > .../bootstrap/en/includes/modals/catalog_cite.inc | 4 ++-- > .../opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 4 ++-- > .../bootstrap/en/modules/opac-curbside-pickups.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt | 5 +++-- > .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 10 ++++++++++ > .../opac-tmpl/bootstrap/en/modules/opac-recalls.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 ++-- > 7 files changed, 21 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc >index d8f3011339..89b5fa845f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc >@@ -4,12 +4,12 @@ > <div class="modal-dialog modal-lg"> > <div class="modal-content"> > <div class="modal-header"> >- <h3 class="modal-title" id="citeModalLabel">[% biblio.title | html %]</h3> >+ <h1 class="modal-title" id="citeModalLabel">[% biblio.title | html %]</h1> > <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> > </div> > <div class="modal-body"> > [% FOREACH system IN cites.keys.sort %] >- <h3>[% system | html %]</h3> >+ <h2>[% system | html %]</h2> > <p>[% cites.$system | html %]</p> > [% END %] > </div> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >index 280e76cfb1..0c812315d8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >@@ -1,14 +1,14 @@ > [% BLOCK shelfbrowser %] > [% IF OpenOPACShelfBrowser %] > <div id="shelfbrowser"> >- <h5 style="text-align: center;" tabindex="-1"> >+ <h2 style="text-align: center;" tabindex="-1"> > [%- IF ( starting_homebranch ) %]<span>Browsing [% starting_homebranch | html %] shelves</span>[% END -%] > [%- IF ( starting_homebranch && starting_location ) %],[% END %] > [%- IF ( starting_location ) %]<span>Shelving location:</span> [%- starting_location | html -%][% END -%] > [%- IF ( starting_homebranch && starting_ccode ) %],[% END %] > [%- IF ( starting_ccode ) %]<span>Collection: [%- starting_ccode | html -%]</span>[% END -%] > <a style="font-size: 75%;" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber | html %]" class="close_shelf">Close shelf browser <span class="sr-only">(Hides shelf browser)</span></a> >- </h5> >+ </h2> > > <table class="table"> > <tr> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >index 638742ab4e..e822aba23b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >@@ -106,7 +106,7 @@ > </div> > <div class="col-md-12 col-lg-10 order-1"> > <div id="pickupdetails" class="maincontent"> >- <h2>Curbside pickups</h2> >+ <h1>Curbside pickups</h1> > > [% FOR m IN messages %] > [% SET alert_type = "alert alert-info" %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >index 476bc3c323..1dd16bcdcc 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >@@ -86,13 +86,13 @@ > [% SET show_author = Koha.Preference('NewsAuthorDisplay') == 'opac' || Koha.Preference('NewsAuthorDisplay') == 'both' %] > [% FOREACH koha_new IN koha_news.content %] > <div class="newsitem"> >- <h4 class="newsheader"> >+ <h2 class="newsheader"> > [% IF ( news_item ) %] > [% koha_new.title | html %] > [% ELSE %] > <a id="newsitem[% koha_new.additional_content.id | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.additional_content.id | uri %]">[% koha_new.title | html %]</a> > [% END %] >- </h4> >+ </h2> > <div class="newsbody">[% koha_new.content | $raw %]</div> > <div class="newsfooter"> > Published on [% koha_new.published_on | $KohaDates %] >@@ -167,6 +167,7 @@ > <form action="/cgi-bin/koha/opac-user.pl" method="post" name="auth" id="auth" autocomplete="off"> > [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="koha_login_context" value="opac" /> >+ <h2 class="sr-only">Login form</h2> > <fieldset class="brief"> > <legend>Log in to your account:</legend> > [% IF ( Koha.Preference('GoogleOpenIDConnect') == 1 ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index c86f9f39e1..5b959c655a 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -152,6 +152,7 @@ > [% IF has_guarantor_flag && !Koha.Preference('OPACPrivacy') && ( Koha.Preference('AllowPatronToSetCheckoutsVisibilityForGuarantor') || Koha.Preference('AllowPatronToSetFinesVisibilityForGuarantor') ) %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Privacy</h2> > <fieldset class="rows" id="memberentry_privacy"> > <legend id="privacy_legend">Privacy</legend> > <ol> >@@ -228,6 +229,7 @@ > [% UNLESS ( hidden.defined('cardnumber') || ( !borrower && Koha.Preference('autoMemberNum') ) ) && hidden.defined('dateexpiry') && hidden.defined('branchcode') && hidden.defined('categorycode') %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Library</h2> > <fieldset class="rows" id="memberentry_library"> > <legend id="library_legend">Library</legend> > <ol> >@@ -373,6 +375,7 @@ > [% UNLESS hidden.defined('title') && hidden.defined('surname') && hidden.defined('firstname') && hidden.defined('preferred_name') && hidden.defined('middle_name') && hidden.defined('dateofbirth') && hidden.defined('initials') && hidden.defined('pronouns') && hidden.defined('othernames') && hidden.defined('sex') %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Identity</h2> > <fieldset class="rows" id="memberentry_identity"> > <legend id="identity_legend">Identity</legend> > >@@ -519,6 +522,7 @@ > [% UNLESS hidden.defined('streetnumber') && hidden.defined('address') && hidden.defined('address2') && hidden.defined('city') && hidden.defined('state') && hidden.defined('zipcode') && hidden.defined('country') %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Main address</h2> > <fieldset class="rows" id="memberentry_mainaddress"> > <legend id="mainaddress_legend">Main address</legend> > >@@ -613,6 +617,7 @@ > [% UNLESS hidden.defined('phone') && hidden.defined('phonepro') && hidden.defined('mobile') && hidden.defined('email') && hidden.defined('emailpro') && hidden.defined('fax') %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Contact information</h2> > <fieldset class="rows" id="memberentry_contact"> > <legend id="contact_legend">Contact information</legend> > >@@ -785,6 +790,7 @@ > [% UNLESS hidden.defined('B_streetnumber') && hidden.defined('B_address') && hidden.defined('B_address2') && hidden.defined('B_city') && hidden.defined('B_state') && hidden.defined('B_zipcode') && hidden.defined('B_country') && hidden.defined('B_phone') && hidden.defined('B_email') && hidden.defined('contactnote') %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Alternate address</h2> > <fieldset class="rows" id="memberentry_alternateaddress"> > <legend id="alternateaddress_legend">Alternate address</legend> > >@@ -905,6 +911,7 @@ > [% UNLESS hidden.defined('altcontactsurname') && hidden.defined('altcontactfirstname') && hidden.defined('altcontactaddress1') && hidden.defined('altcontactaddress2') && hidden.defined('altcontactaddress3') && hidden.defined('altcontactstate') && hidden.defined('altcontactzipcode') && hidden.defined('altcontactcountry') && hidden.defined('altcontactphone') %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Alternate contact</h2> > <fieldset class="rows" id="memberentry_alternatecontact"> > <legend id="alternatecontact_legend">Alternate contact</legend> > >@@ -1006,6 +1013,7 @@ > [% UNLESS op == 'edit' || hidden.defined('password') %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Password</h2> > <fieldset class="rows" id="memberentry_password"> > <legend id="contact_legend">Password</legend> > <div class="alert alert-info"> >@@ -1122,6 +1130,7 @@ > [% IF Koha.Preference('PrivacyPolicyConsent') && op != 'edit' %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Data privacy policy consent</h2> > <fieldset class="rows" id="memberentry_gdpr_consent"> > <legend>Data privacy policy consent</legend> > <ol> >@@ -1145,6 +1154,7 @@ > [% UNLESS op == 'edit' %] > <div class="row"> > <div class="col"> >+ <h2 class="sr-only">Verification</h2> > <fieldset class="rows" id="memberentry_captcha"> > <legend>Verification</legend> > <ol> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >index 7de5d93ae3..d52ccdcc21 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >@@ -26,7 +26,7 @@ > </div> > <div class="col-md-12 col-lg-10 order-1 order-lg-2"> > <div id="recalls" class="maincontent"> >- <h2>Recalls history</h2> >+ <h1>Recalls history</h1> > [% IF Koha.Preference('UseRecalls') %] > [% IF RECALLS.count %] > <div id="opac-user-recalls"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 438878a6f1..0679354bb3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -602,7 +602,7 @@ > <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> > </div> > <div class="modal-body" id="addNoteBody"> >- <h6 id="addNoteTitle"></h6> >+ <h2 id="addNoteTitle"></h2> > <input type="hidden" id="addNoteIssueId" name="issue_id" value="" /> > <textarea name="note" id="addNote" rows="4"></textarea> > <div class="hint">Your note will be shown to the librarian when the item is checked in.</div> >@@ -1045,7 +1045,7 @@ > <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> > </div> > <div class="modal-body"> >- <h6 id="suspendHoldTitle"></h6> >+ <h2 id="suspendHoldTitle"></h2> > <input type="hidden" name="reserve_id" id="suspendHoldReserveId" value="" /> > <label for="suspend_untilDate">Suspend until:</label> > <input type="text" name="suspend_until" id="suspend_untilDate" size="10" /> >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39356
:
179465
|
179473
|
179928
|
180063
|
180224
|
180269