"Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a <h2> is not followed directly by an <h4>, for example. It is ok to skip ranks when closing subsections, for instance, a <h2> beginning a new section, can follow an <h4> as it closes the previous section." For example : I found in Your summary account page in suspend Hold section a <h1> followed directly by an <h6>. https://www.w3.org/WAI/tutorials/page-structure/headings/
(In reply to nina from comment #0) > "Skipping heading ranks can be confusing and should be avoided where > possible: Make sure that a <h2> is not followed directly by an <h4>, for > example. It is ok to skip ranks when closing subsections, for instance, a > <h2> beginning a new section, can follow an <h4> as it closes the previous > section." > >For example, I found that on the 'Your Summary Account' page, in the 'Suspend >Hold' section, an <h1> tag is directly followed by an <h6> tag. > > https://www.w3.org/WAI/tutorials/page-structure/headings/
Created attachment 179465 [details] [review] Bug39356 : Change heading ranks when ranks are skipped Test plan : - Check all headings on the pages (you can use tools like HeadingsMap ) - Verify that no heading ranks are skipped - If it is the case, the test succeeds
Created attachment 179473 [details] [review] Bug 39356 - Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds
I get a sha1 error when trying to apply this patch. I also noticed there is an extra character in opac-main.tt https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179465&action=diff#a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt_sec1 I would help testing to know which pages we should be looking at. :)
Created attachment 179928 [details] [review] Bug 39356: Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds Pages to check: - opac-main.pl - opac-curbside-pickups.pl - opac-memberentry.pl - opac-recalls.pl - opac-user.pl - opac-details.pl (shelf browser, the modal that open after a click on "Cite" in the sidebar)
(In reply to Caroline Cyr La Rose from comment #4) > I get a sha1 error when trying to apply this patch. > > I also noticed there is an extra character in opac-main.tt > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=179465&action=diff#a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac- > main.tt_sec1 > > I would help testing to know which pages we should be looking at. :) This was caused by the first patch not being obsoleted, sorry about that! Submitted new patch with the list of pages to check
It's ok with all the pages but one : opac-details.pl I use the HeadingsMap tool, thanks for the tip ! if I click on a record (to get its details), I just get a 2, without any 1
(In reply to Emmanuel Bétemps from comment #7) > It's ok with all the pages but one : opac-details.pl > > I use the HeadingsMap tool, thanks for the tip ! > if I click on a record (to get its details), I just get a 2, without any 1 This is due to the xslt, normally there are a heading 1 for record title on the details page. Maybe we can solve this problem in an other bug ?
Created attachment 180063 [details] [review] Bug 39356: Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds Pages to check: - opac-main.pl - opac-curbside-pickups.pl - opac-memberentry.pl - opac-recalls.pl - opac-user.pl - opac-details.pl (shelf browser, the modal that open after a click on "Cite" in the sidebar) Signed-off-by: Emmanuel <e.betemps@gmail.com>
For the test plan, it would be useful to include what system preferences need to be turned on to allow access to pages that you need to be tested. Many people will know, but some will not and it is always good to give as much information as possible.
Also tested and signed off.
Created attachment 180224 [details] [review] Bug 39356: Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds Pages to check: - opac-main.pl - opac-curbside-pickups.pl - opac-memberentry.pl - opac-recalls.pl - opac-user.pl - opac-details.pl (shelf browser, the modal that open after a click on "Cite" in the sidebar) Signed-off-by: Emmanuel <e.betemps@gmail.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk>
Created attachment 180269 [details] [review] Bug 39356: Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds Pages to check: - opac-main.pl - opac-curbside-pickups.pl - opac-memberentry.pl - opac-recalls.pl - opac-user.pl - opac-details.pl (shelf browser, the modal that open after a click on "Cite" in the sidebar) Signed-off-by: Emmanuel <e.betemps@gmail.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 25.05! Well done everyone, thank you!