Bugzilla – Attachment 179668 Details for
Bug 39319
xt/author/podcorrectness.t only test POD for perl files within C4 and Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39319: Improve pod_checker.t
Bug-39319-Improve-podcheckert.patch (text/plain), 1.46 KB, created by
Martin Renvoize (ashimema)
on 2025-03-24 16:16:09 UTC
(
hide
)
Description:
Bug 39319: Improve pod_checker.t
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-03-24 16:16:09 UTC
Size:
1.46 KB
patch
obsolete
>From 0e1d5ff27e40173cfad61d125bdcbdc14ebdc169 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 Mar 2025 13:41:52 +0100 >Subject: [PATCH] Bug 39319: Improve pod_checker.t > >It was not failing when warnings were found > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > xt/author/pod_checker.t | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > mode change 100644 => 100755 xt/author/pod_checker.t > >diff --git a/xt/author/pod_checker.t b/xt/author/pod_checker.t >old mode 100644 >new mode 100755 >index 4c7415bb002..b0396640832 >--- a/xt/author/pod_checker.t >+++ b/xt/author/pod_checker.t >@@ -10,8 +10,20 @@ push @files, qx{git ls-files '*.pl' '*.PL' '*.pm' '*.t'}; > push @files, qx{git ls-files svc opac/svc}; # Files without extension > chomp for @files; > >-plan tests => 1; >+plan tests => scalar @files + 1; > > for my $file (@files) { >- podchecker($file); >+ my $checker = Pod::Checker->new(); >+ $checker->parse_from_file( $file, \*STDERR ); >+ my $num_errors = $checker->num_errors; >+ my $num_warnings = $checker->num_warnings; >+ if ( $checker->num_errors > 0 ) { >+ fail("Found pod errors for $file"); >+ } elsif ( $checker->num_errors == -1 ) { >+ pass("Skip pod checker for $file - no pod found"); >+ } elsif ( $checker->num_warnings ) { >+ fail("Found pod warnings for $file"); >+ } else { >+ pass("pod for $file"); >+ } > } >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39319
:
179237
|
179238
|
179274
|
179275
|
179370
|
179371
|
179372
|
179373
|
179450
|
179664
|
179665
|
179666
|
179667
| 179668