Bugzilla – Attachment 180432 Details for
Bug 39530
The MARC ordering cronjob needs to respect the AcqCreateItems syspref
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39530: Make MARC order cronjob dependent on AcqCreateitems
Bug-39530-Make-MARC-order-cronjob-dependent-on-Acq.patch (text/plain), 1.02 KB, created by
Matt Blenkinsop
on 2025-04-03 07:50:55 UTC
(
hide
)
Description:
Bug 39530: Make MARC order cronjob dependent on AcqCreateitems
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2025-04-03 07:50:55 UTC
Size:
1.02 KB
patch
obsolete
>From 7e3d79060abe4df83683797828740d23fa1d0e5c Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Thu, 3 Apr 2025 08:36:43 +0100 >Subject: [PATCH] Bug 39530: Make MARC order cronjob dependent on > AcqCreateitems > >Test plan: >1) View the patch diff and confirm that the hardcoded value of 'ordering' has been replaced with undef >2) In C4/Acquisition.pm, look at the method description for ModBasketHeader and observe the descritpion for 'create_items' >3) Note that if the value is set to undef as per step 1, the AcqCreateItem syspref takes precedence >--- > Koha/MarcOrder.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/MarcOrder.pm b/Koha/MarcOrder.pm >index fa8cc831fe4..658192c8b7c 100644 >--- a/Koha/MarcOrder.pm >+++ b/Koha/MarcOrder.pm >@@ -241,7 +241,7 @@ sub _create_basket_for_file { > > my $basketno = NewBasket( > $vendor_id, 0, $basketname, q{}, >- q{}, q{}, q{}, q{}, 0, 'ordering' >+ q{}, q{}, q{}, q{}, 0, undef > ); > > return $basketno; >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39530
:
180432
|
180447