Bug 39530 - The MARC ordering cronjob needs to respect the AcqCreateItems syspref
Summary: The MARC ordering cronjob needs to respect the AcqCreateItems syspref
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on: 34355
Blocks:
  Show dependency treegraph
 
Reported: 2025-04-02 15:20 UTC by Matt Blenkinsop
Modified: 2025-04-04 07:41 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39530: Make MARC order cronjob dependent on AcqCreateitems (1.02 KB, patch)
2025-04-03 07:50 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 39530: Make MARC order cronjob dependent on AcqCreateitems (1.08 KB, patch)
2025-04-03 08:37 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2025-04-02 15:20:19 UTC
The value is hardcoded to 'ordering' - this needs to be changed
Comment 1 Matt Blenkinsop 2025-04-03 07:50:55 UTC
Created attachment 180432 [details] [review]
Bug 39530: Make MARC order cronjob dependent on AcqCreateitems

Test plan:
1) View the patch diff and confirm that the hardcoded value of 'ordering' has been replaced with undef
2) In C4/Acquisition.pm, look at the method description for ModBasketHeader and observe the descritpion for 'create_items'
3) Note that if the value is set to undef as per step 1, the AcqCreateItem syspref takes precedence
Comment 2 Nick Clemens (kidclamp) 2025-04-03 08:37:01 UTC
Created attachment 180447 [details] [review]
Bug 39530: Make MARC order cronjob dependent on AcqCreateitems

Test plan:
1) View the patch diff and confirm that the hardcoded value of 'ordering' has been replaced with undef
2) In C4/Acquisition.pm, look at the method description for ModBasketHeader and observe the descritpion for 'create_items'
3) Note that if the value is set to undef as per step 1, the AcqCreateItem syspref takes precedence

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 3 Nick Clemens (kidclamp) 2025-04-03 08:37:53 UTC
Tested using test plan from 39518 andd verified create_items setting in the new basket - trivial patch, PQA