Bugzilla – Attachment 180623 Details for
Bug 39561
Users with only editcatalogue: fast_cataloging cannot easily add an item if a duplicate is found
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39561: Allow users with fast_cataloging to continue after duplicate is found
Bug-39561-Allow-users-with-fastcataloging-to-conti.patch (text/plain), 5.39 KB, created by
Nick Clemens (kidclamp)
on 2025-04-04 09:52:59 UTC
(
hide
)
Description:
Bug 39561: Allow users with fast_cataloging to continue after duplicate is found
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-04-04 09:52:59 UTC
Size:
5.39 KB
patch
obsolete
>From 8c4e2415ee870d7a96d8bf1b20316eaf11d04443 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 4 Apr 2025 09:20:57 +0000 >Subject: [PATCH] Bug 39561: Allow users with fast_cataloging to continue after > duplicate is found > >This patch adds the fast_cataloging permission to those checked when a duplicate is found > >Additionally, the barcode was missing from the duplicate check and is now added to be passed forward > >To test: > 1 - Create or choose a borrower and grant permissions: > catalogue > circulate > borrowers: list_borrowers > editcatalogue: fast_cataloguing > 2 - Log in as that patron > 3 - Search for another borrower and go to checkout screen > 4 - Enter random string as barcode to checkout > 5 - Item is not found, click to fast catalogue > 6 - In the editor type into 245$a 'Perl best practices' - or another title that exists in your system > 7 - Get a notice of duplicate with options: > Yes: View existing items > No, save as new record > 8 - Clicking 'Yes' will take you to the record details page - you cannot add an item because record is not FA framework > 9 - You can click 'back' to return to the messages >10 - Clicking 'No' will create a new record and take you to the details page - you can add an item (Edit->manage items) > but barcode has been dropped >11 - Apply patch >12 - Repeate 3-6 >13 - You now get options: > Yes: View existing items (you cannot add items to an existing record) > No, save as new record >14 - 'Yes' will take you to details view >15 - Click back >16 - 'No' will take you to the edit items screen and populate the barcode >17 - Saving the item should return you to patron and issue item >18 - Repeat again with a staff patron with full permissions and confirm saying 'Yes' completes the fast catalogin workflow as expected >--- > .../prog/en/modules/cataloguing/addbiblio.tt | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index ad4d899fa63..83cbed751d5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -861,9 +861,21 @@ > > > [% IF ( CAN_user_editcatalogue_edit_items ) %] > <form action="/cgi-bin/koha/cataloguing/additem.pl" method="get"> >+ [% IF ( circborrowernumber ) # It is possible we have come from fast cataloging - include the fields %] >+ <input type="hidden" name="barcode" value="[% barcode | html %]" /> >+ <input type="hidden" name="branch" value="[% branch | html %]" /> >+ <input type="hidden" name="circborrowernumber" value="[% circborrowernumber | html %]" /> >+ <input type="hidden" name="stickyduedate" value="[% stickyduedate | html %]" /> >+ <input type="hidden" name="duedatespec" value="[% duedatespec | html %]" /> >+ [% END %] > <input type="hidden" name="biblionumber" value="[% duplicatebiblionumber | html %]" /> > <button type="submit" class="new"><i class="fa-fw fa-solid fa-pencil" aria-hidden="true"></i> Yes, edit existing items</button> > </form> >+ [% ELSIF ( circborrowernumber ) # Coming from fast cataloging %] >+ <form action="/cgi-bin/koha/catalogue/detail.pl" method="get"> >+ <input type="hidden" name="biblionumber" value="[% duplicatebiblionumber | html %]" /> >+ <input type="submit" value="Yes: View existing items (you may not add items to existing records)" /> >+ </form> > [% ELSE %] > <form action="/cgi-bin/koha/catalogue/detail.pl" method="get"> > <input type="hidden" name="biblionumber" value="[% duplicatebiblionumber | html %]" /> >@@ -871,7 +883,14 @@ > </form> > [% END %] > <form action="/cgi-bin/koha/cataloguing/addbiblio.pl" method="get"> >- [% IF ( CAN_user_editcatalogue_edit_items ) %] >+ [% IF ( CAN_user_editcatalogue_edit_items || CAN_user_editcatalogue_fast_cataloging ) %] >+ [% IF ( circborrowernumber ) # It is possible we have come from fast cataloging - include the fields %] >+ <input type="hidden" name="barcode" value="[% barcode | html %]" /> >+ <input type="hidden" name="branch" value="[% branch | html %]" /> >+ <input type="hidden" name="circborrowernumber" value="[% circborrowernumber | html %]" /> >+ <input type="hidden" name="stickyduedate" value="[% stickyduedate | html %]" /> >+ <input type="hidden" name="duedatespec" value="[% duedatespec | html %]" /> >+ [% END %] > <button type="submit" class="new" onclick="confirmnotdup('items'); return false;"><i class="fa fa-fw fa-save"></i> No, save as new record</button> > [% ELSE %] > <button type="submit" class="new" onclick="confirmnotdup('view'); return false;"><i class="fa fa-fw fa-save"></i> No, save as new record</button> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39561
:
180623
|
180886