Bugzilla – Attachment 180717 Details for
Bug 39576
'Last patron' results should display preferred name
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39576: Show preferred_name for hiddenborrowername
Bug-39576-Show-preferredname-for-hiddenborrowernam.patch (text/plain), 1.75 KB, created by
Andrew Fuerste-Henry
on 2025-04-08 12:36:32 UTC
(
hide
)
Description:
Bug 39576: Show preferred_name for hiddenborrowername
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-04-08 12:36:32 UTC
Size:
1.75 KB
patch
obsolete
>From 58eb2ba669314da26284a5e2a1baf0c96062cd4b Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Tue, 8 Apr 2025 12:32:04 +0000 >Subject: [PATCH] Bug 39576: Show preferred_name for hiddenborrowername > >The last patron menu uses the value "hiddenborrowername." I've made that use preferred_name instead of firstname. When a patron's preferred_name is not manually set/edited, it automatically takes the value of firstname, so we don't need an IF in the template toolkit here. > >To test: >1 - have a patron with a preferred_name and one without >2 - get both patrons in the Last Patron dropdown, confirm they both show firstname >3 - apply patch, restart services, clear cache, reload page >4 - get your patrons in Last Patron again, confirm now one shows preferred name and the other firstname >--- > koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index f913c07c36..9eb6432712 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -27,7 +27,7 @@ > > [% IF Koha.Preference('showLastPatron') %] > <input type="hidden" id="hiddenborrowernumber" value="[% patron.borrowernumber | html %]" /> >- <input type="hidden" id="hiddenborrowername" value="[% patron.surname | html %] [% patron.firstname | html %]" /> >+ <input type="hidden" id="hiddenborrowername" value="[% patron.surname | html %] [% patron.preferred_name | html %]" /> > <input type="hidden" id="hiddenborrowercard" value="[% patron.cardnumber | html %]" /> > [% END %] > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39576
:
180717
|
180982
|
182281