The "Last Patron" search function lists [Last name] [first name] [card number] With the new preferred name field, it would be nice if the last patron results showed [last name] [preferred name] [card number]
Created attachment 180717 [details] [review] Bug 39576: Show preferred_name for hiddenborrowername The last patron menu uses the value "hiddenborrowername." I've made that use preferred_name instead of firstname. When a patron's preferred_name is not manually set/edited, it automatically takes the value of firstname, so we don't need an IF in the template toolkit here. To test: 1 - have a patron with a preferred_name and one without 2 - get both patrons in the Last Patron dropdown, confirm they both show firstname 3 - apply patch, restart services, clear cache, reload page 4 - get your patrons in Last Patron again, confirm now one shows preferred name and the other firstname
Created attachment 180982 [details] [review] Bug 39576: Show preferred_name for hiddenborrowername The last patron menu uses the value "hiddenborrowername." I've made that use preferred_name instead of firstname. When a patron's preferred_name is not manually set/edited, it automatically takes the value of firstname, so we don't need an IF in the template toolkit here. To test: 1 - have a patron with a preferred_name and one without 2 - get both patrons in the Last Patron dropdown, confirm they both show firstname 3 - apply patch, restart services, clear cache, reload page 4 - get your patrons in Last Patron again, confirm now one shows preferred name and the other firstname Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Thanks for signing off, Emmanuel. I am putting this in signed off status.
Hi, you're welcome ! (the hardest thing was to find how displaying the last patron dropdown... thanks to the manual ^^) Manu.
Created attachment 182281 [details] [review] Bug 39576: Show preferred_name for hiddenborrowername The last patron menu uses the value "hiddenborrowername." I've made that use preferred_name instead of firstname. When a patron's preferred_name is not manually set/edited, it automatically takes the value of firstname, so we don't need an IF in the template toolkit here. To test: 1 - have a patron with a preferred_name and one without 2 - get both patrons in the Last Patron dropdown, confirm they both show firstname 3 - apply patch, restart services, clear cache, reload page 4 - get your patrons in Last Patron again, confirm now one shows preferred name and the other firstname Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Pushed for 25.05! Well done everyone, thank you!