Bugzilla – Attachment 181022 Details for
Bug 38984
DataTables's columnDefs cleanup
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38984: Replace nosort with NoSort
Bug-38984-Replace-nosort-with-NoSort.patch (text/plain), 11.55 KB, created by
Owen Leonard
on 2025-04-16 16:03:39 UTC
(
hide
)
Description:
Bug 38984: Replace nosort with NoSort
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-04-16 16:03:39 UTC
Size:
11.55 KB
patch
obsolete
>From fdbb9fc6a5d559b765f65879213e9f136fabd553 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 28 Jan 2025 10:56:41 +0100 >Subject: [PATCH] Bug 38984: Replace nosort with NoSort > >We don't need nosort and NoSort, use NoSort everywhere > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > .../prog/en/modules/recalls/recalls_to_pull.tt | 3 +-- > .../prog/en/modules/recalls/recalls_waiting.tt | 5 ++--- > koha-tmpl/intranet-tmpl/prog/js/recalls.js | 1 - > .../opac-tmpl/bootstrap/en/modules/opac-recalls.tt | 3 +-- > .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 13 ++++++------- > .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 3 +-- > 6 files changed, 11 insertions(+), 17 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_to_pull.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_to_pull.tt >index e2c576b4a9d..f4249d55edc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_to_pull.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_to_pull.tt >@@ -54,7 +54,7 @@ > <th class="recall-itemtypes">Available item types</th> > <th class="recall-locations">Available locations</th> > <th class="recall-date title-string">Earliest recall date</th> >- <th class="recall-action nosort"> </th> >+ <th class="recall-action NoSort"> </th> > </tr> > </thead> > <tbody> >@@ -153,7 +153,6 @@ > $(document).ready(function () { > $("#recalls-table").kohaTable({ > columnDefs: [ >- { orderable: false, targets: ["nosort"] }, > { type: "title-string", targets: ["title-string"] }, > { type: "anti-the", targets: ["anti-the"] }, > ], >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt >index 08a392eeec0..79f45415ef1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt >@@ -51,7 +51,7 @@ > <th class="recall-title anti-the">Title</th> > <th class="recall-patron">Requested by</th> > <th class="recall-library">Pickup location</th> >- <th class="recall-action nosort"> </th> >+ <th class="recall-action NoSort"> </th> > </tr></thead > > > <tbody> >@@ -104,7 +104,7 @@ > <th class="recall-title anti-the">Title</th> > <th class="recall-patron">Requested by</th> > <th class="recall-library">Pickup location</th> >- <th class="recall-action nosort"> </th> >+ <th class="recall-action NoSort"> </th> > </tr></thead > > > <tbody> >@@ -158,7 +158,6 @@ > $(document).ready(function () { > $("#recallswaiting-table, #recallsover-table").kohaTable({ > autoWidth: false, >- columnDefs: [{ orderable: false, targets: ["nosort"] }], > pagingType: "full_numbers", > }); > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/recalls.js b/koha-tmpl/intranet-tmpl/prog/js/recalls.js >index 0833d181f3c..826c2745003 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/recalls.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/recalls.js >@@ -129,7 +129,6 @@ $(document).ready(function () { > > $("#recalls-table").kohaTable({ > columnDefs: [ >- { orderable: false, targets: ["nosort"] }, > { type: "title-string", targets: ["title-string"] }, > { type: "anti-the", targets: ["anti-the"] }, > ], >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >index 8d77a81bbb7..b6203aa2aac 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >@@ -39,7 +39,7 @@ > <th>Pickup location</th> > <th>Status</th> > <th>Due date</th> >- <th class="nosort">Modify</th> >+ <th class="NoSort">Modify</th> > <th></th> > </tr> > </thead> >@@ -140,7 +140,6 @@ > details: { type: "column", target: -1 }, > }, > columnDefs: [ >- { targets: ["nosort"], orderable: false, searchable: false }, > { type: "anti-the", targets: ["anti-the"] }, > { className: "dtr-control", orderable: false, targets: -1 }, > ], >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 8a90f4de21b..cde66d43eaf 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -337,7 +337,7 @@ > <caption>[% issues_count | html %] Item(s) checked out</caption> > <thead> > <tr> >- [% IF ( JacketImages ) %]<th class="nosort"> </th>[% END %] >+ [% IF ( JacketImages ) %]<th class="NoSort"> </th>[% END %] > <th class="all anti-the">Title</th> > <th>Author</th> > <th class="psort">Due</th> >@@ -355,11 +355,11 @@ > <th>Fines</th> > [% END %] > [% IF Koha.Preference('OPACMySummaryHTML') %] >- <th class="nosort">Links</th> >+ <th class="NoSort">Links</th> > [% END %] > [% IF ( Koha.Preference('AllowCheckoutNotes') ) %] > <th class="hidden">Checkout note</th> >- <th id="checkout-notes" class="nosort noExport" title="Use this to report any problems with your currently checked out items">Report a problem</th> >+ <th id="checkout-notes" class="NoSort noExport" title="Use this to report any problems with your currently checked out items">Report a problem</th> > [% END %] > <th></th> > </tr> >@@ -728,14 +728,14 @@ > <!-- OVERDUES TABLE ROWS --> > <thead> > <tr> >- [% IF ( JacketImages ) %]<th class="nosort"> </th>[% END %] >+ [% IF ( JacketImages ) %]<th class="NoSort"> </th>[% END %] > <th class="all anti-the">Title</th> > [% UNLESS ( item_level_itypes ) %]<th>Item type</th>[% END %] > [% IF ( show_barcode ) %]<th>Barcode</th>[% END %] > <th>Call number</th> > <th class="psort">Due</th> > [% IF ( OpacRenewalAllowed ) %] >- <th class="nosort">Renew</th> >+ <th class="NoSort">Renew</th> > [% END %] > [% IF ( OPACFinesTab ) %] > <th>Fines</th> >@@ -862,7 +862,7 @@ > <th>Expires on</th> > <th>Pickup location</th> > <th>Status</th> >- <th class="nosort"> </th> >+ <th class="NoSort"> </th> > <th></th> > </tr> > </thead> >@@ -1210,7 +1210,6 @@ > "sorting" : [[ thIndex, 'asc' ]], > "dom": '<"top"<"table_entries"><"table_controls"fB>>t', > "columnDefs": [ >- { "targets": [ "nosort" ],"orderable": false,"searchable": false }, > { "type": "anti-the", "targets" : [ "anti-the" ] }, > { "visible": false, "targets" : [ "hidden" ] }, > { "className": 'dtr-control', "orderable": false, "targets": -1 } >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index 52530b7e18a..1fadebaf37b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -180,7 +180,7 @@ > <th class="all anti-the">Title</th> > <th>Call number</th> > <th class="psort">Due</th> >- <th class="all nosort">Renew</th> >+ <th class="all NoSort">Renew</th> > [% UNLESS ( nofines ) %] > <th>Fines</th> > [% END %] >@@ -462,7 +462,6 @@ > sorting: [[thIndex, "asc"]], > dom: '<"top"<"table_entries"><"table_controls"f>>t<"clear">', > columnDefs: [ >- { targets: ["nosort"], orderable: false, searchable: false }, > { targets: ["noshow"], visible: false, searchable: false }, > { type: "anti-the", targets: ["anti-the"] }, > { visible: false, targets: ["hidden"] }, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38984
:
177253
|
177254
|
177255
|
177256
|
177257
|
177258
|
177259
|
177278
|
177279
|
177280
|
177281
|
177597
|
177598
|
177641
|
177642
|
177643
|
177644
|
177645
|
177646
|
177647
|
177648
|
177649
|
177651
|
177933
|
177934
|
177935
|
177936
|
177937
|
177938
|
177939
|
177940
|
177941
|
177942
|
179057
|
179058
|
179059
|
179060
|
179061
|
179062
|
179063
|
179064
|
179065
|
179066
|
180303
|
180356
|
180357
|
180358
|
180359
|
180360
|
180361
|
180362
|
180363
|
180364
|
180365
|
180366
|
181021
| 181022 |
181023
|
181024
|
181025
|
181026
|
181027
|
181028
|
181029
|
181030
|
181031