We don't need to have a columnDefs for NoSort or anti-the, they are already defined in the global datatables.js
Created attachment 177253 [details] [review] Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js
Created attachment 177254 [details] [review] Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere
Created attachment 177255 [details] [review] Bug 38984: Remove anti-the Same as previouly for anti-the
Created attachment 177256 [details] [review] Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values
Created attachment 177257 [details] [review] Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields
Created attachment 177258 [details] [review] Bug 38984: Also make 'Actions' translatable
Created attachment 177259 [details] [review] Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result?
Also tempted to rename NoSort with no-sort and NoExport with no-export, to match string-sort, anti-the, etc.
(In reply to Jonathan Druart from comment #8) > Also tempted to rename NoSort with no-sort and NoExport with no-export, to > match string-sort, anti-the, etc. And it's "noExport"...
Created attachment 177278 [details] [review] Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values
Created attachment 177279 [details] [review] Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields
Created attachment 177280 [details] [review] Bug 38984: Also make 'Actions' translatable
Created attachment 177281 [details] [review] Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result?
Created attachment 177597 [details] [review] Bug 38984: Also make 'Actions' translatable Current status: Patch doesn't apply
Created attachment 177598 [details] [review] Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result?
Created attachment 177641 [details] [review] Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 177642 [details] [review] Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 177643 [details] [review] Bug 38984: Remove anti-the Same as previouly for anti-the Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 177644 [details] [review] Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 177645 [details] [review] Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 177646 [details] [review] Bug 38984: Also make 'Actions' translatable Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 177647 [details] [review] Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 177648 [details] [review] Bug 38984: (follow-up) Fix syntax error in invoice-files table
Created attachment 177649 [details] [review] Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option).
Created attachment 177651 [details] [review] Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging"
Created attachment 177933 [details] [review] Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js
Created attachment 177934 [details] [review] Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere
Created attachment 177935 [details] [review] Bug 38984: Remove anti-the Same as previouly for anti-the
Created attachment 177936 [details] [review] Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values
Created attachment 177937 [details] [review] Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields
Created attachment 177938 [details] [review] Bug 38984: Also make 'Actions' translatable
Created attachment 177939 [details] [review] Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result?
Created attachment 177940 [details] [review] Bug 38984: (follow-up) Fix syntax error in invoice-files table
Created attachment 177941 [details] [review] Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option).
Created attachment 177942 [details] [review] Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging"
Created attachment 179057 [details] [review] Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js
Created attachment 179058 [details] [review] Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere
Created attachment 179059 [details] [review] Bug 38984: Remove anti-the Same as previouly for anti-the
Created attachment 179060 [details] [review] Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values
Created attachment 179061 [details] [review] Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields
Created attachment 179062 [details] [review] Bug 38984: Also make 'Actions' translatable
Created attachment 179063 [details] [review] Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result?
Created attachment 179064 [details] [review] Bug 38984: (follow-up) Fix syntax error in invoice-files table
Created attachment 179065 [details] [review] Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option).
Created attachment 179066 [details] [review] Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging"
I'd love to also see the suggested NoSort -> no-sort and NoExport to no-export change.. that would be nice
We are missing noExport from datatables.js
(In reply to Jonathan Druart from comment #47) > We are missing noExport from datatables.js Forget that, it's something else.
Created attachment 180303 [details] [review] Bug 38984: Uniformize noSort NoExport NoExport
Created attachment 180356 [details] [review] Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180357 [details] [review] Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180358 [details] [review] Bug 38984: Remove anti-the Same as previouly for anti-the Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180359 [details] [review] Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180360 [details] [review] Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180361 [details] [review] Bug 38984: Also make 'Actions' translatable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180362 [details] [review] Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180363 [details] [review] Bug 38984: (follow-up) Fix syntax error in invoice-files table Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180364 [details] [review] Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180365 [details] [review] Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 180366 [details] [review] Bug 38984: Uniformize noSort NoExport NoExport Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Thanks for the tidy up here Jonathan :)
Can you please rebase? There is a conflict in sco-main I am not sure about.
Created attachment 181021 [details] [review] Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181022 [details] [review] Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181023 [details] [review] Bug 38984: Remove anti-the Same as previouly for anti-the Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181024 [details] [review] Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181025 [details] [review] Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181026 [details] [review] Bug 38984: Also make 'Actions' translatable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181027 [details] [review] Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181028 [details] [review] Bug 38984: (follow-up) Fix syntax error in invoice-files table Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181029 [details] [review] Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181030 [details] [review] Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181031 [details] [review] Bug 38984: Uniformize noSort NoExport NoExport Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Maybe we could add a little summary for devs on what to use when now?
Pushed for 25.05! Well done everyone, thank you!
(In reply to Katrin Fischer from comment #74) > Maybe we could add a little summary for devs on what to use when now? I've done a little updating to this page: https://wiki.koha-community.org/wiki/DataTables_HowTo. There's probably more to be done.
(In reply to Owen Leonard from comment #76) > (In reply to Katrin Fischer from comment #74) > > Maybe we could add a little summary for devs on what to use when now? > > I've done a little updating to this page: > https://wiki.koha-community.org/wiki/DataTables_HowTo. There's probably more > to be done. That's awesome thanks :) Wondering if we can delete this line and fix the file name? WARNING: H::T::P has been dropped from the official codebase so what follows is not applicable to current coding standards... you have been warned. koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/issues.tmpl:
(In reply to Katrin Fischer from comment #77) > (In reply to Owen Leonard from comment #76) > > (In reply to Katrin Fischer from comment #74) > > > Maybe we could add a little summary for devs on what to use when now? > > > > I've done a little updating to this page: > > https://wiki.koha-community.org/wiki/DataTables_HowTo. There's probably more > > to be done. > > That's awesome thanks :) > > Wondering if we can delete this line and fix the file name? > > WARNING: H::T::P has been dropped from the official codebase so what follows > is not applicable to current coding standards... you have been warned. > > koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/issues.tmpl: Yes, and add an "OBSOLETE" flag at the top of the page as well... It needs to be rewritten.