Bugzilla – Attachment 181144 Details for
Bug 38650
We should only fill title level or specific item holds when a patron checks out an item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38650: Only fill title level reserves, or reserves on the exact item
Bug-38650-Only-fill-title-level-reserves-or-reserv.patch (text/plain), 2.71 KB, created by
Nick Clemens (kidclamp)
on 2025-04-17 20:28:00 UTC
(
hide
)
Description:
Bug 38650: Only fill title level reserves, or reserves on the exact item
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-04-17 20:28:00 UTC
Size:
2.71 KB
patch
obsolete
>From cf3feda85bd0b6a9cb734f5b4e37b339b0529f63 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 9 Dec 2024 20:23:11 +0000 >Subject: [PATCH] Bug 38650: Only fill title level reserves, or reserves on the > exact item > >We change the conditions for filling holds to require that either: >- the hold is title level >- the hold is on the exact item > >To test: > 1 - Place a hold for patron A on item #1 of a record > 2 - Place a hold for patron B on item #2 of a record > 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in > 4 - Apply patch, restart all > 5 - Place hold for patron A on item #1 > 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in > 7 - Cancel that hold > 8 - Place a title level hold for the record for patron A > 9 - Check item #1 in at a different branch and confirm transfer > 9 - Issue item #2 to patron A >10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in >11 - Place an item level hold for item #2 for patron A >12 - Issue item #2 to patron A, hold is filled >--- > C4/Reserves.pm | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 432ae461dc5..45eae2c1819 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -2021,23 +2021,27 @@ sub MoveReserve { > my $lookahead = C4::Context->preference('ConfirmFutureHolds'); #number of days to look for future holds > my $item = Koha::Items->find($itemnumber); > my ( $restype, $res, undef ) = CheckReserves( $item, $lookahead ); >- return unless $res; > >- my $biblionumber = $res->{biblionumber}; >- >- if ( $res->{borrowernumber} == $borrowernumber ) { >+ if ( $res && $res->{borrowernumber} == $borrowernumber ) { > my $hold = Koha::Holds->find( $res->{reserve_id} ); > $hold->fill( { item_id => $itemnumber } ); > } else { > >- # warn "Reserved"; > # The item is reserved by someone else. > # Find this item in the reserves > >+ my $lookahead_date = output_pref( >+ { >+ dt => dt_from_string->add_duration( DateTime::Duration->new( days => $lookahead ) ), >+ dateformat => 'iso', dateonly => 1 >+ } >+ ); > my $borr_res = Koha::Holds->search( > { > borrowernumber => $borrowernumber, >- biblionumber => $biblionumber, >+ biblionumber => $item->biblionumber, >+ reservedate => { '<=' => $lookahead_date }, >+ -or => [ item_level_hold => 0, itemnumber => $itemnumber ], > }, > { order_by => 'priority' } > )->next(); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38650
:
175335
|
175336
|
181143
|
181144
|
181369
|
181370
|
182017
|
182018